enhancement: allow specifying a location name when using the /onecall endpoint in the OpenWeatherMap module

[efkann]

What problem do you want to solve with this change?

Hi,

With the recent changes in OpenWeatherMap, version 2.5 has been deprecated, and version 3.0 is now the default.

But the /onecall endpoint returns a timezone rather than a location name. Currently, the returned timezone is used to set the location in the module.

MagicMirror/modules/default/weather/providers/openweathermap.js

Lines 36 to 38 in 9c9a535

	if (this.config.weatherEndpoint === "/onecall") {
	currentWeather = this.generateWeatherObjectsFromOnecall(data).current;
	this.setFetchedLocation(`${data.timezone}`);

MagicMirror/modules/default/weather/providers/openweathermap.js

Lines 56 to 58 in 9c9a535

	if (this.config.weatherEndpoint === "/onecall") {
	forecast = this.generateWeatherObjectsFromOnecall(data).days;
	location = `${data.timezone}`;

What do you think is the correct solution?

Since the user already provides the lat and lon values in the configuration, I see no harm in adding an optional field like locationName to use when the endpoint is set to /onecall.

What do you think ?

I’d be happy to submit a PR to implement these changes.

Participation

• I am willing to submit a pull request for this change.

Additional comments

I understand that there's already a location field in the config, but this field is consumed with other endpoints. So, I believe it wouldn't be a good practice to reuse the same field for a different purpose in the /onecall endpoint.

[sdetweil]

just use the module header option

{
module:"weather",
position:"....",
header:"whatever you want",
config:{
   appendLocationToHeader:false,
    other config parms
  }
)

[efkann]

just use the module header option { module:"weather", position:"....", header:"whatever you want", config:{ appendLocationToHeader:false, other config parms } )

Didn't know this was possible, thanks.