Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Fix and Complete Implementation of WeatherFlow provider #3728

Open
4 tasks done
n8many opened this issue Feb 26, 2025 · 2 comments
Open
4 tasks done

Comments

@n8many
Copy link

n8many commented Feb 26, 2025

Prerequisites

  • I am running the latest version of MagicMirror², and know that this feature is not available now.
  • I know my issue is not related to a third-party module.
  • I have searched for existing issues that already include this feature request, without success.

Describe the Feature Request

The current implementation of the WeatherFlow weather provider has a couple small bugs (broken icons mostly) and does not use all of the data provided by the API that WeatherFlow supports.

Describe the Use Case

For those of us with WeatherFlow systems, it would be nice to have more of the data displayed on the mirror.

Describe Preferred Solution

I have completed this implementation on my end and added precipitation amount, UV index, hourly weather support, and station name display. Can I make a pull request to merge this feature into the project?

Describe Alternatives

I can also supply code snippets for implementation internally.

Related Code

No response

Additional Information

No response

Participation

  • I am willing to submit a pull request for this change.
@sdetweil
Copy link
Collaborator

you can always submit

does it pass the weather tests?
you need your add tests for your additional data display

tests are in the tests folder

a config for your module, there is a mock data to return specific data block
and tests for elements on page

npm run test:electron
npm run test:e2e

@n8many
Copy link
Author

n8many commented Feb 28, 2025

So, I have not added any new data to the weather module, only filled out existing fields in the WeatherObject via the weatherflow.js provider. So the tests should be untouched. I will open up a PR so you can see the extent of the changes, but they should pass the tests.

rejas pushed a commit that referenced this issue Mar 1, 2025
I have updated weatherflow.js to implement the following changes (as
described in #3728)

- Fixed: Weather icons now show up properly
- Added: Location Name support
- Added: Hourly weather forecast support
- Added to current conditions:
  - "Feels like" temp
- Fixed icon for current conditions to be sourced from current
conditions (rather than daily forecast)
  - UV index
- Added to daily forecast
  - Precipitation amount and UV index (via hourly forecast data)

Before:

![image](https://github.com/user-attachments/assets/cfef043c-75ef-4571-8bdc-462e75d3ed81)

After:

![image](https://github.com/user-attachments/assets/e36118bb-a508-4ab1-a7ad-a775bd7a9bb3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants