-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight typing hints in a different color than ordinary code. #183
Comments
I agree. Would be nice to be able to apply a different color to type hints. I get the impression a lot of people like them to be just regular code. I'm fine with that as the default, but would be nice to add an extra label so some of us can for example make all type hints semi-transparent. |
There are also the type hints on function defs. And they very much deserve some highlighting. def fun_func(
big_param: Set[Tuple[int, int]],
generic_param: List[T],
) -> Mapping[str, T]: ... |
Type annotations of the attributes of a dataclass need proper highlighting as well: Number = Union[int, float]
@dataclass(frozen=True)
class SomeClass:
foo: Generator[AnyStr, Number, None] = field(hash=False)
bar: Iterable[T] = field(compare=False)
amount: Number = -1 |
When using generic types (typevar) on classes (inheriting from it), no highlighting appears. V = TypeVar("V", FirstType, SomeOtherType)
E = TypeVar("E")
class StopIgnoringMe(Generic[V, E], ParentClass):
pass
class NormalInheritance(ParentClass):
pass |
I'll see what I can do to highlight type hints better. I guess the starting point would be to at least give them all a scope of their own like |
@vpetrovykh do you need help with the issue? |
It appears Github's highlighting decided that everything that starts with a capital letter deserves that same color. |
I'd also like to have a separate scope for type hints. |
For having the same scope |
To change color of type hints in VSCode you can use editor settings ...
"editor.semanticTokenColorCustomizations": {
"[Visual Studio Light]": {
// Apply to this theme only
"enabled": true,
"rules": {
"*.typeHint:python": "#e4c8c8"
}
}
}
... |
Typing hints are displayed in the same color as python variables and statements.
That looks somewhat confusing and makes it harder to see at once where is a typing hint, where a variable name is defined and where is an actual code.
E.g., the line below up to 'origin' is in the same color.
The text was updated successfully, but these errors were encountered: