Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to IzzyOnDroid #1

Open
6 tasks done
asandikci opened this issue Jul 26, 2024 · 11 comments
Open
6 tasks done

Add to IzzyOnDroid #1

asandikci opened this issue Jul 26, 2024 · 11 comments
Labels
ci related with ci/cd (github actions/fdroid etc)

Comments

@asandikci
Copy link
Member

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for Tubular itself and that requests for adding a new service need to be made in vanilla NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the vanilla NewPipe contribution guidelines.

Feature description

Add .apk file to IzzyOnDroid repo

Why do you want this feature?

for making easy to update application

Why ist the feature relevant to this fork?

because output is a different .apk file 🤡

Additional information

No response

@asandikci
Copy link
Member Author

Note: This issue is for reminder purposes only. I don't think it's ethical to put an already existing app in an app store under a different name without making any changes, so I won't make such a request until I make changes at a different point and break away from the original Tubular (at least until we merge the BraveNewpipe fork? Maybe?). Until then, people can update it manually via GitHub or Obtainium

asandikci pushed a commit that referenced this issue Nov 25, 2024
…-change

Fix Crash on Related Items Modal
asandikci pushed a commit that referenced this issue Dec 6, 2024
@asandikci asandikci added the ci related with ci/cd (github actions/fdroid etc) label Jan 10, 2025
@chpio
Copy link

chpio commented Jan 23, 2025

I don't think it's ethical to put an already existing app in an app store under a different name without making any changes

Hmm, but does an abandoned non functional app count as "existing" in this case?

@asandikci
Copy link
Member Author

It was not abandoned when I wrote this lines, maybe we can reconsider to publish it earlier. But app logo and name texts should be changed before it at least

@asandikci
Copy link
Member Author

you can use our own f-droid repo until we did changes for publishing to IzzyOnDroid
https://maintainteam.github.io/fdroid-pages/

@chpio

This comment has been minimized.

@asandikci
Copy link
Member Author

@IzzySoft are you accepting duplicate projects if previous one has been abandoned (I mean Tubular) I know I should change icon / app name but are there any other thing that I should make/know to listed on your repo? I want to apply with extended version if you accept 😊

@asandikci
Copy link
Member Author

and is 6 months enough to say the app has been abandoned?

@IzzySoft
Copy link
Contributor

You use your own packageName there: org.maintainteam.lastpipebender.extended – so I don't see any collision. It's an extended version (the name suggests), so it's no duplicate either. Why not then? Things to be done for that:

  • graphics need to be updated (icon is from Tubular, featureGraphic explicitly states Tubular, screenshots I didn't check)
  • short/fulldesc I didn't review. Please make sure to have them up-to-date
  • library scanner reports ACRA. It's hopefully opt-in? Else it would mean the Tracking anti-feature.
  • permissions: here we'd need an explanation on at least android.permission.SYSTEM_ALERT_WINDOW and android.permission.READ_EXTERNAL_STORAGE (rather WRITE, as READ was added implicitly), for transparency.

All else seems fine so far. So if you give me a ping when it's ready, I take another look – and we see to get it rolling!

@asandikci
Copy link
Member Author

asandikci commented Jan 25, 2025

and is 6 months enough to say the app has been abandoned?

It is not I guess :d
Tubular also released latest version. It would be meaningful to delay this because even extended version almost same to Tubular

@Kelvino9

This comment has been minimized.

@IzzySoft
Copy link
Contributor

IzzySoft commented Feb 9, 2025

Just ping me when you're ready. So far (apart from pulling in upstream's updates as you described), I see the following open points:

  • fastlane is still the original Tubular one.
  • once more fastlane: as there are 2 different builds, with different feature sets, we'd need 2 fastlane trees. You can take a look at the IzzyOnDroid Fastlane Documentation for how to accomplish that (or where to locate the two, ideally; our updater can pick fastlane from individual locations, it's configurable – but it cannot hurt to rather stick to the standards 😉)
  • the app icon (in res/mipmap-*) is still the one from Tubular. Nothing wrong with an icon based on that, as the app is based on Tubular as well – but we'd need to have it distinguishable from Tubular's.
  • a statement whether ACRA is opt-in (which it should ideally be, else the app would need to be flagged with the Tracking anti-feature)
  • an explanation for the above mentioned permissions (for transparency, IoD shows them with its repo browser)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci related with ci/cd (github actions/fdroid etc)
Projects
None yet
Development

No branches or pull requests

4 participants