Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings->Config->Access Control->Group "assigned filters" clusters "tab" missing vendor-embedded_terraform.svg and vendor-ibm_cic_cinder.svg #9355

Open
jrafanie opened this issue Feb 20, 2025 · 4 comments
Open

Settings->Config->Access Control->Group "assigned filters" clusters "tab" missing vendor-embedded_terraform.svg and vendor-ibm_cic_cinder.svg #9355

jrafanie opened this issue Feb 20, 2025 · 4 comments
Assignees
@Fryguy
Labels
bug rails7.1

Comments

@jrafanie
Copy link
Member

jrafanie commented Feb 20, 2025 •
edited
Loading

This is a problem in rails 7.0 and 7.1 but 7.1 loudly fails whereas 7.0 shows a broken image. Note, in production mode, rails 7.1 raises the error seen in the second screenshot. In rails 7.0, it logs an error but it's doesn't raise an error and draws a broken image in the tree instead. Rails 7.0 behavior is shown first:

Rails 7.0:

Image

7.0 output: 
[----] D, [2025-02-20T12:28:08.343469#93840:ebac8] DEBUG -- : PostgreSQLAdapter#log_after_checkin, connection_pool: size: 15, connections: 2, in use: 0, waiting_in_queue: 0
[----] I, [2025-02-20T12:28:08.359900#93840:ebac8]  INFO -- : Started GET "/images/svg/vendor-embedded_terraform.svg" for ::1 at 2025-02-20 12:28:08 -0500
[----] I, [2025-02-20T12:28:08.386630#93840:f3f48]  INFO -- : Started GET "/images/svg/vendor-ibm_cic_cinder.svg" for ::1 at 2025-02-20 12:28:08 -0500
[----] F, [2025-02-20T12:28:08.480685#93840:ebac8] FATAL -- :
ActionController::RoutingError (No route matches [GET] "/images/svg/vendor-embedded_terraform.svg"):

actionpack (7.0.8.7) lib/action_dispatch/middleware/debug_exceptions.rb:32:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/show_exceptions.rb:29:in `call'
railties (7.0.8.7) lib/rails/rack/logger.rb:40:in `call_app'
railties (7.0.8.7) lib/rails/rack/logger.rb:27:in `call'
sprockets-rails (3.5.2) lib/sprockets/rails/quiet_assets.rb:17:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/remote_ip.rb:93:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/request_id.rb:26:in `call'
rack (2.2.11) lib/rack/method_override.rb:24:in `call'
rack (2.2.11) lib/rack/runtime.rb:22:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/executor.rb:14:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/static.rb:23:in `call'
rack (2.2.11) lib/rack/sendfile.rb:110:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/host_authorization.rb:138:in `call'
secure_headers (3.9.0) lib/secure_headers/middleware.rb:12:in `call'
railties (7.0.8.7) lib/rails/engine.rb:530:in `call'
railties (7.0.8.7) lib/rails/railtie.rb:226:in `public_send'
railties (7.0.8.7) lib/rails/railtie.rb:226:in `method_missing'
puma (6.6.0) lib/puma/configuration.rb:279:in `call'
puma (6.6.0) lib/puma/request.rb:99:in `block in handle_request'
puma (6.6.0) lib/puma/thread_pool.rb:390:in `with_force_shutdown'
puma (6.6.0) lib/puma/request.rb:98:in `handle_request'
puma (6.6.0) lib/puma/server.rb:472:in `process_client'
puma (6.6.0) lib/puma/server.rb:254:in `block in run'
puma (6.6.0) lib/puma/thread_pool.rb:167:in `block in spawn_thread'
[----] F, [2025-02-20T12:28:08.487369#93840:f3f48] FATAL -- :
ActionController::RoutingError (No route matches [GET] "/images/svg/vendor-ibm_cic_cinder.svg"):

actionpack (7.0.8.7) lib/action_dispatch/middleware/debug_exceptions.rb:32:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/show_exceptions.rb:29:in `call'
railties (7.0.8.7) lib/rails/rack/logger.rb:40:in `call_app'
railties (7.0.8.7) lib/rails/rack/logger.rb:27:in `call'
sprockets-rails (3.5.2) lib/sprockets/rails/quiet_assets.rb:17:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/remote_ip.rb:93:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/request_id.rb:26:in `call'
rack (2.2.11) lib/rack/method_override.rb:24:in `call'
rack (2.2.11) lib/rack/runtime.rb:22:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/executor.rb:14:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/static.rb:23:in `call'
rack (2.2.11) lib/rack/sendfile.rb:110:in `call'
actionpack (7.0.8.7) lib/action_dispatch/middleware/host_authorization.rb:138:in `call'
secure_headers (3.9.0) lib/secure_headers/middleware.rb:12:in `call'
railties (7.0.8.7) lib/rails/engine.rb:530:in `call'
railties (7.0.8.7) lib/rails/railtie.rb:226:in `public_send'
railties (7.0.8.7) lib/rails/railtie.rb:226:in `method_missing'
puma (6.6.0) lib/puma/configuration.rb:279:in `call'
puma (6.6.0) lib/puma/request.rb:99:in `block in handle_request'
puma (6.6.0) lib/puma/thread_pool.rb:390:in `with_force_shutdown'
puma (6.6.0) lib/puma/request.rb:98:in `handle_request'
puma (6.6.0) lib/puma/server.rb:472:in `process_client'
puma (6.6.0) lib/puma/server.rb:254:in `block in run'
puma (6.6.0) lib/puma/thread_pool.rb:167:in `block in spawn_thread'

Rails 7.1:

Image

7.1 output: 
[----] F, [2025-02-20T12:26:56.321444#97699:f49c0] FATAL -- : Error caught: [Sprockets::Rails::Helper::AssetNotFound] The asset "svg/vendor-embedded_terraform.svg" is not present in the asset pipeline.

/Users/joerafaniello/.gem/ruby/3.3.6/gems/sprockets-rails-3.5.2/lib/sprockets/rails/helper.rb:84:in `compute_asset_path'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.1.5.1/lib/action_view/helpers/asset_url_helper.rb:204:in `asset_path'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.1.5.1/lib/action_view/helpers/asset_url_helper.rb:379:in `image_path'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/presenters/tree_node/node.rb:51:in `to_h'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/presenters/tree_builder.rb:260:in `x_build_node'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/presenters/tree_builder.rb:208:in `block in x_build_tree'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activerecord-7.1.5.1/lib/active_record/relation/delegation.rb:100:in `each'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activerecord-7.1.5.1/lib/active_record/relation/delegation.rb:100:in `each'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/presenters/tree_builder.rb:203:in `map'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/presenters/tree_builder.rb:203:in `x_build_tree'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/presenters/tree_builder.rb:155:in `build_tree'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/presenters/tree_builder.rb:22:in `initialize'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/presenters/tree_builder_belongs_to_hac.rb:21:in `initialize'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/controllers/ops_controller/ops_rbac.rb:935:in `new'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/controllers/ops_controller/ops_rbac.rb:935:in `rbac_group_right_tree'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/controllers/ops_controller/ops_rbac.rb:887:in `rbac_group_get_details'
/Users/joerafaniello/.gem/ruby/3.3.6/bundler/gems/manageiq-ui-classic-75d5211b3207/app/controllers/ops_controller.rb:300:in `rbac_group_load_tab'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/abstract_controller/base.rb:224:in `process_action'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_controller/metal/rendering.rb:165:in `process_action'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/abstract_controller/callbacks.rb:259:in `block in process_action'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.1.5.1/lib/active_support/callbacks.rb:110:in `run_callbacks'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/abstract_controller/callbacks.rb:258:in `process_action'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_controller/metal/rescue.rb:25:in `process_action'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_controller/metal/instrumentation.rb:74:in `block in process_action'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.1.5.1/lib/active_support/notifications.rb:206:in `block in instrument'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.1.5.1/lib/active_support/notifications/instrumenter.rb:58:in `instrument'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.1.5.1/lib/active_support/notifications.rb:206:in `instrument'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_controller/metal/instrumentation.rb:73:in `process_action'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_controller/metal/params_wrapper.rb:261:in `process_action'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activerecord-7.1.5.1/lib/active_record/railties/controller_runtime.rb:32:in `process_action'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/abstract_controller/base.rb:160:in `process'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.1.5.1/lib/action_view/rendering.rb:40:in `process'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_controller/metal.rb:227:in `dispatch'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_controller/metal.rb:309:in `dispatch'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/routing/route_set.rb:49:in `dispatch'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/routing/route_set.rb:32:in `serve'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/journey/router.rb:51:in `block in serve'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/journey/router.rb:131:in `block in find_routes'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/journey/router.rb:124:in `each'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/journey/router.rb:124:in `find_routes'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/journey/router.rb:32:in `serve'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/routing/route_set.rb:882:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/rack-attack-6.5.0/lib/rack/attack.rb:113:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/routes_lazy_routes-0.4.3/lib/routes_lazy_routes/lazy_routes_middleware.rb:16:in `call'
/Users/joerafaniello/Code/manageiq/lib/request_started_on_middleware.rb:12:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/rack-2.2.11/lib/rack/tempfile_reaper.rb:15:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/rack-2.2.11/lib/rack/etag.rb:27:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/rack-2.2.11/lib/rack/conditional_get.rb:40:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/rack-2.2.11/lib/rack/head.rb:12:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/http/permissions_policy.rb:36:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/http/content_security_policy.rb:36:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/rack-2.2.11/lib/rack/session/abstract/id.rb:266:in `context'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/rack-2.2.11/lib/rack/session/abstract/id.rb:260:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/middleware/cookies.rb:689:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activerecord-7.1.5.1/lib/active_record/migration.rb:655:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/activesupport-7.1.5.1/lib/active_support/callbacks.rb:101:in `run_callbacks'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/middleware/callbacks.rb:28:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/middleware/executor.rb:14:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/middleware/debug_exceptions.rb:29:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/middleware/show_exceptions.rb:31:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/railties-7.1.5.1/lib/rails/rack/logger.rb:37:in `call_app'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/railties-7.1.5.1/lib/rails/rack/logger.rb:26:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/sprockets-rails-3.5.2/lib/sprockets/rails/quiet_assets.rb:17:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/middleware/remote_ip.rb:92:in `call'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionpack-7.1.5.1/lib/action_dispatch/m...
[----] I, [2025-02-20T12:26:56.322047#97699:f49c0]  INFO -- : Completed 200 OK in 621ms (Views: 0.2ms | ActiveRecord: 55.0ms | Allocations: 1658835)
@jrafanie jrafanie added the bug label Feb 20, 2025
@jrafanie jrafanie changed the title Configuration -> Access Control -> Group "assigned filters" bottom frame - switching to cluster view - missing vendor-embedded_terraform.svg and vendor-ibm_cic_cinder.svg Config->Access Control->Group "assigned filters" bottom frame-switch to cluster view - missing vendor-embedded_terraform.svg and vendor-ibm_cic_cinder.svg Feb 20, 2025
@jrafanie
Copy link
Member Author

Note, missing vendor-ibm_cic_cinder.svg also causes a difference in loading in Storage -> Volumes page for 7.0 vs. 7.1

Rails 7.0: ActionController::RoutingError (No route matches [GET] "/images/svg/vendor-ibm_cic_cinder.svg"

Image

Rails 7.1:

[----] F, [2025-02-20T12:54:58.874486#97699:f49c0] FATAL -- : Error caught: [Sprockets::Rails::Helper::AssetNotFound] The asset "svg/vendor-ibm_cic_cinder.svg" is not present in the asset pipeline.

/Users/joerafaniello/.gem/ruby/3.3.6/gems/sprockets-rails-3.5.2/lib/sprockets/rails/helper.rb:84:in `compute_asset_path'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.1.5.1/lib/action_view/helpers/asset_url_helper.rb:204:in `asset_path'
/Users/joerafaniello/.gem/ruby/3.3.6/gems/actionview-7.1.5.1/lib/action_view/helpers/asset_url_helper.rb:379:in `image_path'

Image

@Fryguy
Copy link
Member

Fryguy commented Feb 20, 2025

CIC asset is interesting in that it is part of the plugin itself as opposed to in decorators where everything else is:

https://github.com/ManageIQ/manageiq-providers-ibm_cic/tree/master/app/assets/images/svg

@Fryguy
Copy link
Member

Fryguy commented Feb 20, 2025

Oh wait, these don't exist - totally misread and thought it was cic as opposed to cic_cinder.

@Fryguy Fryguy self-assigned this Feb 26, 2025
@jrafanie jrafanie changed the title Config->Access Control->Group "assigned filters" bottom frame-switch to cluster view - missing vendor-embedded_terraform.svg and vendor-ibm_cic_cinder.svg Settings->Config->Access Control->Group "assigned filters" clusters "tab" missing vendor-embedded_terraform.svg and vendor-ibm_cic_cinder.svg Feb 26, 2025
@jrafanie
Copy link
Member Author

Marking as rails 7.1 as now the missing image fails the page loading whereas previously, the rest of the page will load in spite of the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fryguy Fryguy

Labels
bug rails7.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrafanie @Fryguy