Skip to content

Latest commit

 

History

History
25 lines (22 loc) · 1.5 KB

feedback.md

File metadata and controls

25 lines (22 loc) · 1.5 KB

Remarks

  • Code: no oop and huge try statement, not a good practice. It's not clean (no typing, no docstring)
  • notebooks ok
  • No useless branches on github 👍
  • correlation analysis a bit vague
  • good strategy to get the distribution per province and critical and non critical columns
  • Good git usage 🔥 but try not pushing so many similar commits
  • dataset absolute path hardcoded in dashboard, gave an error while launching and using streamlit. Use relative path instead
  • Good idea to create a streamlit 🔥
  • The presentation was not as good as it could have been, I understand working as a team is not always an easy task but you managed to present something it's already positive.
  • Analysis was good and insights relevant

Evaluation Criteria

Criteria Indicator Yes/No
Completeness Answered all outlined questions Yes
Used pandas, matplotlib, or seaborn Yes
Presented analysis results effectively No
Clean, well-structured code No
Comprehensive README Yes
Excellence Answered additional creative questions Yes
Addressed bonus questions Yes
Used effective colors in visualizations Yes