Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev Work] Redesign ComicInfo class #145

Open
1 of 5 tasks
ThePromidius opened this issue Feb 12, 2023 · 0 comments
Open
1 of 5 tasks

[Dev Work] Redesign ComicInfo class #145

ThePromidius opened this issue Feb 12, 2023 · 0 comments
Assignees
@majora2007 @ThePromidius
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
v1.0.0-beta.3

Comments

@ThePromidius
Copy link
Member

ThePromidius commented Feb 12, 2023 •
edited by majora2007
Loading

While the comicinfo class was reworked to a simple to use data class it still has limitations.

The objectives of this story are:

  • Redesign the class.
  • Implement an all in one solution.
  • Reduce code duplication of this code (in the ui, defaults are manually imposed as well as default option list. Move all this to one single place)
  • Unit testing
  • Small PRs at a time
@ThePromidius ThePromidius added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 12, 2023
@ThePromidius ThePromidius added this to the v1.0.0-beta.2 - Rework milestone Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majora2007 majora2007

@ThePromidius ThePromidius

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Manga Manager Rewrite
Status: No status
Milestone
v1.0.0-beta.3
Development

No branches or pull requests
2 participants
@majora2007 @ThePromidius