Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Compatibility with Roll Groups #331

Open
maxobremer opened this issue Feb 13, 2024 · 1 comment
Open

[FEATURE] Compatibility with Roll Groups #331

maxobremer opened this issue Feb 13, 2024 · 1 comment
Assignees
Labels
feature New feature or request

Comments

@maxobremer
Copy link

Is your feature request related to a problem? Please describe.
At the moment with the way how dnd5e (v3) handles damage rolls its somewhat difficult to split damage rolls by their type. The Roll Groups module kinda helps with this as it allows you to create different groups that can all be rolled separately. The downside is that the damage buttons for roll groups get disabled if you roll with the ready set roll damage roll button on the chat card. It would be nice if the ready set roll damage card gets removed from the item card in chat if different roll groups are assigned to an item and if possible that those damage rolls are integrated into the item card like the normal ready set roll damage chat cards. This would be nice for stuff like the Ice Knife spells or the Giant Spider's Bite which both have conditional damage.

Describe the solution you'd like
If Roll Groups are enabled that the roll groups are used to determine the damage button on the chat card and if possible that they are integrated into the chat card itself and not make new rolls.

Describe alternatives you've considered
Using Roll Groups and Ready Set Roll as is, telling my players to not click the damage button.

Additional context
Great work so far on the module and getting it to dnd5e v3. Out of curiosity, what is the next thing you will work on/prioritise for this module?
also here is a screenshot how it looks currently with both modules
image

@MangoFVTT
Copy link
Owner

MangoFVTT commented Feb 14, 2024

Great work so far on the module and getting it to dnd5e v3. Out of curiosity, what is the next thing you will work on/prioritise for this module?

Next priority is stabilising the module for v3, then working on improving how RSR picks up hooks so that it plays better with other modules that also pick up the same hook. This should inherently also improve it's compatibility with Roll Groups, and hopefully resolve this ticket in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants