Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If-statement rewriting leading to broken AST? #11

Closed
pjattke opened this issue Apr 28, 2020 · 1 comment
Closed

If-statement rewriting leading to broken AST? #11

pjattke opened this issue Apr 28, 2020 · 1 comment
Assignees
@AlexanderViand

Comments

@pjattke
Copy link
Contributor

pjattke commented Apr 28, 2020

I suspect that the If-statement rewriting will break the AST if certain non-rewriteable statements are in the Then- or Else-branch, for example, a For-loop.

A test must be added to verify or falsify the CompileTimeExpressionSimplifier's result if an If-statement includes a For-loop.
@pjattke pjattke added class CTES check required Unconfirmed issues or suspicions requiring investigation labels Apr 28, 2020
@AlexanderViand AlexanderViand self-assigned this Nov 10, 2020
@AlexanderViand
Copy link
Collaborator

The new SecretBranchingVisitor in v2.0 addresses this, as verified by TEST(SecretBranchingVisitorTest, secretVariable_ifBranch_unsupportedBodyFor_noRewritingExpected)

@AlexanderViand AlexanderViand removed the check required Unconfirmed issues or suspicions requiring investigation label Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexanderViand AlexanderViand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexanderViand @pjattke