Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix access tracking to ControlFlowGraphVisitor #14

Closed
pjattke opened this issue Apr 28, 2020 · 1 comment
Closed

Add matrix access tracking to ControlFlowGraphVisitor #14

pjattke opened this issue Apr 28, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@pjattke
Copy link
Contributor

pjattke commented Apr 28, 2020

The ControlFlowGraphVisitor currently uses a std::vector<std::string> to store the variable that are accessed (read or written). This, however, is not enough as there might exists multiple variables with the same identifier but declared in different scopes. See #13 that addresses this issue.

In addition to the missing scope support, it would be useful to allow tracking of matrix accesses. As a current and very rudimentary workaround, a string like "Variable(M)[LiteralInt(21)][LiteralInt(3)]" is constructed and used. As we cannot generally assume that indices are always known, it would probably better to store the whole MatrixElementRef element.

@pjattke pjattke added the enhancement New feature or request label Apr 28, 2020
@AlexanderViand
Copy link
Collaborator

I'm assuming this is now dealt with differently in the CFGV since we've introduced the Target class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants