HECO doesn't build against MLIR commit on July 18th, 2024

[ai-mannamalai]

HECO doesn't build against MLIR commit on July 18th, 2024
llvm/llvm-project@a41a4b8

with the error,

n file included from /Users/mannamalai/devel/HECO/include/heco/IR/FHE/FHEDialect.h:4:
/usr/local/include/mlir/IR/Builders.h:511:11: error: no matching member function for call to 'build'
  511 |     OpTy::build(*this, state, std::forward<Args>(args)...);
      |     ~~~~~~^~~~~
/usr/local/include/mlir/IR/PatternMatch.h:537:18: note: in instantiation of function template specialization 'mlir::OpBuilder::create<mlir::emitc::CallOp, mlir::TypeRange, llvm::StringRef, mlir::ArrayAttr, mlir::ArrayAttr, llvm::SmallVector<mlir::Value> &>' requested here
  537 |     auto newOp = create<OpTy>(op->getLoc(), std::forward<Args>(args)...);
      |                  ^
/Users/mannamalai/devel/HECO/src/Passes/fhe2emitc/LowerFHEToEmitC.cpp:235:18: note: in instantiation of function template specialization 'mlir::RewriterBase::replaceOpWithNewOp<mlir::emitc::CallOp, mlir::TypeRange, llvm::StringRef, mlir::ArrayAttr, mlir::ArrayAttr, llvm::SmallVector<mlir::Value> &>' requested here
  235 |         rewriter.replaceOpWithNewOp<emitc::CallOp>(
      |                  ^
/Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/usr/include/c++/v1/__memory/unique_ptr.h:689:30: note: in instantiation of member function 'EmitCArithmeticPattern<heco::fhe::MultiplyOp>::matchAndRewrite' requested here
  689 |   return unique_ptr<_Tp>(new _Tp(_VSTD::forward<_Args>(__args)...));
      |                              ^
/usr/local/include/mlir/IR/PatternMatch.h:278:14: note: in instantiation of function template specialization 'std::make_unique<EmitCArithmeticPattern<heco::fhe::MultiplyOp>, mlir::TypeConverter &, mlir::MLIRContext *>' requested here
  278 |         std::make_unique<T>(std::forward<Args>(args)...);
      |              ^
/usr/local/include/mlir/IR/PatternMatch.h:990:25: note: in instantiation of function template specialization 'mlir::RewritePattern::create<EmitCArithmeticPattern<heco::fhe::MultiplyOp>, mlir::TypeConverter &, mlir::MLIRContext *>' requested here
  990 |         RewritePattern::create<T>(std::forward<Args>(args)...);
      |                         ^
/usr/local/include/mlir/IR/PatternMatch.h:850:6: note: in instantiation of function template specialization 'mlir::RewritePatternSet::addImpl<EmitCArithmeticPattern<heco::fhe::MultiplyOp>, mlir::TypeConverter &, mlir::MLIRContext *>' requested here
  850 |     (addImpl<Ts>(/*debugLabels=*/std::nullopt,
      |      ^
/Users/mannamalai/devel/HECO/src/Passes/fhe2emitc/LowerFHEToEmitC.cpp:359:14: note: in instantiation of function template specialization 'mlir::RewritePatternSet::add<EmitCReturnPattern, EmitCArithmeticPattern<heco::fhe::SubOp>, EmitCArithmeticPattern<heco::fhe::AddOp>, EmitCArithmeticPattern<heco::fhe::MultiplyOp>, EmitCRotatePattern, EmitCCombinePattern, EmitCFunctionPattern, mlir::TypeConverter &, mlir::MLIRContext *, void>' requested here
  359 |     patterns.add<

[AlexanderViand-Intel]

Sorry, I somehow missed this issue!

HECO has its LLVM/MLIR dependency pinned to llvm/llvm-project@4592543 via git submodule (see https://github.com/MarbleHE/HECO/tree/main/dependencies).

While that commit is already about a year old, with active development having moved to google/heir, I'm unlikely to get around to updating it to a more recent version. However, I'd be happy to accept PRs that update the llvm commit and fix any compile issues :)