Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AbstractNode::supportsCircuitMode #9

Closed
6 tasks
pjattke opened this issue Apr 28, 2020 · 1 comment
Closed
6 tasks

Remove AbstractNode::supportsCircuitMode #9

pjattke opened this issue Apr 28, 2020 · 1 comment
Labels
maintenance Improves the codebase but does not involve new functionality

Comments

@pjattke
Copy link
Contributor

pjattke commented Apr 28, 2020

The method AbstractNode::supportsCircuitMode is obsolete and its naming is confusing. Its initial intention was to provide a way to distinguish between AST nodes that use the AbstractNode's children/parent vector and those that do not. As now almost all AST nodes use the children vector to store its attributes, the method is not required anymore.

  • Adapt CallExternal: Store attributes in AbstractNode's children vector
  • Check if any class still does not use the children/parent vectors to store its attributes
    • Check if any class does not overwrite the inherited method AbstractNode::supportsCircuitMode
    • Check if the overwrite of AbstractNode::supportsCircuitMode in any class returns False
    • Check and remove usages of AbstractNode::supportsCircuitMode
  • Remove the method AbstractNode::supportsCircuitMode
@pjattke pjattke added the maintenance Improves the codebase but does not involve new functionality label Apr 28, 2020
@AlexanderViand
Copy link
Collaborator

CircuitMode is no longer a concept in the new smart-pointer-based ast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improves the codebase but does not involve new functionality
Projects
None yet
Development

No branches or pull requests

2 participants