Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

FishyTurtle #12

Open
crabdancing opened this issue Sep 24, 2020 · 10 comments
Open

FishyTurtle #12

crabdancing opened this issue Sep 24, 2020 · 10 comments
Labels
enhancement make something that already exists better feature an addition

Comments

@crabdancing
Copy link

Fishing is a very boring repetitive task. There are many mods that automate this, but they do so in uninteresting ways that don't tend to have much challenge. It should be possible to equip a turtle with a fishing rod and make a FishyTurtle, and automate it via programming! :D

I've discussed this with upstream, and it seems like the upstream obstacles shouldn't apply to Fabric due to the mixin system. The only thing is that downstream might end up having some unique features that upstream doesn't, if upstream doesn't feel like using MixinBootstrap or a similar solution. How do we feel about this?

@Devan-Kerman
Copy link
Collaborator

mixin is now included in forge so they shouldn't have a problem

@crabdancing
Copy link
Author

Whoops, it's supposed to be marked as a feature request, not a bug...

@Devan-Kerman Devan-Kerman added enhancement make something that already exists better feature an addition and removed bug labels Sep 24, 2020
@crabdancing
Copy link
Author

@Devan-Kerman it looks like upstream is reluctant to implement this, so it might end up being a fabric-exclusive feature if we implement it here.

@Devan-Kerman
Copy link
Collaborator

we decided not to have any fabric-exclusive features and to rather make an extension mod later on to make it easier to track upstream

@crabdancing
Copy link
Author

Damn, I guess it won't get added to either version unless upstream changes their mind. :(

I'd be willing to work on a ComputerCraft addon for FishyTurtle once I get a bit more modding practice. Can you point me to some example code that extends CC-tweaked-fabric?

@Devan-Kerman
Copy link
Collaborator

I actually dunno how the CC:T api works, I just helped porting the mod, but digging around the code and mixing in whenever u need something changed is prolly the extent of my knowledge

@crabdancing
Copy link
Author

Damn, fair enough.

@crabdancing
Copy link
Author

I've never actually made mixins for another mod -- only Minecraft itself. Is mod loading order something to be concerned about, and how should it be addressed?

@Devan-Kerman
Copy link
Collaborator

no, just remember @Mixin(remap = false)

@crabdancing
Copy link
Author

Okay, thanks! ^_^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement make something that already exists better feature an addition
Projects
None yet
Development

No branches or pull requests

2 participants