Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capstone-Project Setup #21

Open
Marlyn-Mayienga opened this issue Sep 6, 2022 · 2 comments
Open

Capstone-Project Setup #21

Marlyn-Mayienga opened this issue Sep 6, 2022 · 2 comments

Comments

@Marlyn-Mayienga
Copy link
Owner

Marlyn-Mayienga commented Sep 6, 2022

In this module, we:

@tresorsawasawa
Copy link

STATUS: REQUIRED CHANGES ♻️♻️

Hi @Marlyn-Mayienga and @Ademola-coding
Good job so far! I know you worked hard to implement this project, I really appreciate the effort you put in! But there are some issues that you still need to work on to go to the next project but you are almost there!

almost-there

To highlight 🍾

  • Good issue description ✔️

Required changes ♻️ ♻️

  • Kindly make sure the link you add in the above issue(link to your GitHub project) is for you the Kanban board and not for the repository. Make sure you update it as required for this project.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @tresorsawasawa when you comment so I can receive the notification or use slack with the same name.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@t-yanick
Copy link

t-yanick commented Sep 6, 2022

Hi Team,

Great job !!!

To Highlight! 👏 🟢

✔️ Descriptive issue summary

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants