Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting namespace/package name with upstream pymatgen #1

Open
ml-evs opened this issue Nov 22, 2022 · 2 comments
Open

Conflicting namespace/package name with upstream pymatgen #1

ml-evs opened this issue Nov 22, 2022 · 2 comments

Comments

@ml-evs
Copy link
Member

ml-evs commented Nov 22, 2022

Just ran into an issue we should have perhaps foreseen... the current package clashes with the existing pymatgen.io.lammps namespace 🙃

@ml-evs ml-evs changed the title Conflicting namespace/package name Conflicting namespace/package name with upstream pymatgen Nov 22, 2022
@gbrunin
Copy link
Member

gbrunin commented Nov 23, 2022

Yes indeed, I discussed that with David yesterday. The last "real" (others than linting etc) developments in the original pymatgen.io.lammps are more than 1 year old, so the idea is to open an issue on pymatgen asking if it's ok to move all of that in our add-on (which is what I did already) and simply remove the existing namespace.

@JaGeo
Copy link

JaGeo commented Nov 23, 2022

Yes, just do this and see what they say. I think you probably need to tag the previous developers and see if they are okay with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants