Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest add option to don't show sign #91

Open
hiberabyss opened this issue Mar 9, 2016 · 2 comments
Open

Suggest add option to don't show sign #91

hiberabyss opened this issue Mar 9, 2016 · 2 comments

Comments

@hiberabyss
Copy link

In most cases, I just want to jump to the right place from the bookmark list, I don't care which line in current file is a bookmark or annotation, so show signs is useless for me.

  • Can there be an option like g:bookmark_sign_disable? When it is set, then no signs will be shown.
  • There can be a command BookmarkSignToggle, which control whether show the signs or not.

Another little problem: when run vim directly without opening a file, then run :Unite vim_bookmarks, following error message will be shown

[unite.vim] unite buffer "default" candidates are empty

Thanks.

@reorx
Copy link

reorx commented Aug 31, 2019

Hi check my comment at #124, you might be interested

@MattesGroeger
Copy link
Owner

Hi @hiberabyss,

thanks for the suggestion of this feature. I do understand your reasoning/use-case.

Thx @reorx for investigating this already.

This is what you wrote in #124:

I explored the code and figured out how to disable signs (added a new option bookmark_sign_disabled), but because the line highlighting feature relies on the sign (which is actually vim's built-in sign feature), it's not possible to keep line highlight while simply disable the sign. According to my very limited vim script knowledge, using match group for lines should be able to achieve that (see this article), but I'm not experienced enough to refactor in that way.

If you are interested in my implementation (can only disable sign and line highlight simultaneously), tell me and I will upload the code to a fork repo.

Do you have any update on the feasibility of this? It sounds like it requires a rather different implementation and would make this plugin quite complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants