Skip to content

Commit

Permalink
Merge pull request #178 from Merck/release-1-0-4
Browse files Browse the repository at this point in the history
CRAN 1.0.4 release
  • Loading branch information
nanxstats authored Jun 18, 2023
2 parents 047946d + a178123 commit 5b6e9e2
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 5 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: r2rtf
Title: Easily Create Production-Ready Rich Text Format (RTF) Table and Figure
Version: 1.0.3
Version: 1.0.4
Authors@R: c(
person("Yilong", "Zhang", email = "[email protected]", role = c("aut", "cre")),
person("Siruo", "Wang", role = "aut"),
Expand Down
8 changes: 8 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# r2rtf 1.0.4 (2023-06-17)

## Bug fixes

* Page size of the first page is different from the other pages (#174).

# r2rtf 1.0.3 (2023-05-26)

## Bug fixes

* Properly display cell height in HTML output (#66).
* Fix an issue when `group_by` and `page_by` are used together (#168).

Expand Down
10 changes: 6 additions & 4 deletions tests/testthat/test-independent-testing-rtf_encode_table.R
Original file line number Diff line number Diff line change
Expand Up @@ -332,16 +332,18 @@ test_that("Test case when using subline_by, page_by, group_by simultaneously wit
attr(ae_t3, "page")$page_title <- "first"
ae_t3a <- rtf_encode_table(ae_t3)

tmp <- lapply(strsplit(ae_t3a$body, "\\page", fixed = TRUE)[[1]],
function(x) grepl("subline", x)
tmp <- lapply(
strsplit(ae_t3a$body, "\\page", fixed = TRUE)[[1]],
function(x) grepl("subline", x)
)
expect_true(tmp[[1]])

attr(ae_t3, "page")$page_title <- "last"
ae_t3b <- rtf_encode_table(ae_t3)

tmp <- lapply(strsplit(ae_t3b$body, "\\page", fixed = TRUE)[[1]],
function(x) grepl("subline", x)
tmp <- lapply(
strsplit(ae_t3b$body, "\\page", fixed = TRUE)[[1]],
function(x) grepl("subline", x)
)
expect_true(tmp[[length(tmp)]])
})

0 comments on commit 5b6e9e2

Please sign in to comment.