Rename foo()

[nanxstats]

There is an internal function defined inline named foo():

wpgsd/R/calc_seq_p.R

Line 74 in 2214c5d

foo <- function(x) {

This function should be updated:

1. Rename it to use a meaningful function name. See foo in Google's developer documentation style guide.
2. Define it outside the export function. This is because currently this is only accessible within the parent function, and it is being redefined again every time the parent function is called, which is suboptimal for performance.

[nanxstats]

@fb-elong Any suggestions on how to name this function?

[elong0527]

How about get_seq_p?

[nanxstats]

@elong0527 Sounds good to me. I would also appreciate renaming the variable hhh which is a bit random.

[fb-elong]

Seems the action item is

foo -> get_seq_p
hhh -> i.

@LittleBeannie, would you ok to create a PR for this when you get a chance?

[nanxstats]

@fb-elong Feel free to fork this repo and send PR from there.