remove copy_file_range (eliminates seg fault on many systems.) #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #111, there are segmentation faults on ubuntu 24.04. I do not know why. This routine accepts file descriptors... and those descriptors need to be subsequently closed, so the file will be published when the close happens anyways. There is no need for this entry point. When I remove this routine, stuff stops crashing. One possibility is that calculating the checksum involves reading the file again, possibly opening and re-closing it. just a guess. I hope I am not just masking the problem by removing a simple cause, but the change is good anyways.
petersilva
changed the title
reidsunderland
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #111
In #111, there are segmentation faults on ubuntu 24.04. I do not know why. This routine accepts file descriptors... and those descriptors need to be subsequently closed, so the file will be published when the close happens anyways. There is no need for this entry point.
When I remove this routine, stuff stops crashing. One possibility is that calculating the checksum involves reading the file again, possibly opening and re-closing it. just a guess. I hope I am not just masking the problem by removing a simple cause, but the change is good anyways.