Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file names with spaces were url encoded. wrongly. #195

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

petersilva
Copy link
Contributor

I was playing with hpc-mirroring use case and noticed this problem. C and python implementations

I see the python does not do this, and I noticed it broke mirroring when files on the source tree had spaces the C would post with %20, which confused the heck out of the python.

I first tried adding %20 encoding on the python side... but it was a spiral downward... backed up.. and decided removal of the url encoding was the better ... um... path. yeah. that's the issue... you don't need url encoding if your value is a path (a file name) but you do if the value is part of a url for some protocols like http. So at some point will have to figure out places to add url encoding.

for now, for file: urls', the answer is ... never.

I see the python does not do this, and I noticed it broke
mirroring when files on the source tree had spaces the C would
post with %20, which confused the heck out of the python.
@petersilva petersilva merged commit e479cab into development Jan 10, 2025
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants