file names with spaces were url encoded. wrongly. #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing with hpc-mirroring use case and noticed this problem. C and python implementations
I see the python does not do this, and I noticed it broke mirroring when files on the source tree had spaces the C would post with %20, which confused the heck out of the python.
I first tried adding %20 encoding on the python side... but it was a spiral downward... backed up.. and decided removal of the url encoding was the better ... um... path. yeah. that's the issue... you don't need url encoding if your value is a path (a file name) but you do if the value is part of a url for some protocols like http. So at some point will have to figure out places to add url encoding.
for now, for file: urls', the answer is ... never.