Export key derivation options #33
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
export-encryption-details
branch
2 times, most recently
from
82efed9 to
afc318d
Compare
Key derivation options are now exported from the functions `keyFromPassword` and `encryptWithDetail`. This can allow the project using this package to store the key derivation options alongside the vault, allowing for easier migrations to newer derivation options in the future.
Gudahtt
force-pushed
the
export-encryption-details
branch
from
afc318d to
26cf6a5
Compare
|
I don't think this is valuable until we support some alternative options. Putting this on the backburner until we decide on how to improve our key generation. |
|
One easy way to improve generation would be to simply add more hash cycles. Current vaults could be made harder to crack. |
|
Yeah, maybe for now we can add support just for that. And we can set a minimum of the current number of cycles that we use. I would like to preserve a minimum level of safety with the options we allow. That's the only reason I'm hesitating to allow further configuration; I don't know how to ensure a minimum level of safety across all of these controls. |
Kuntree12
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key derivation options are now exported from the functions
keyFromPasswordandencryptWithDetail. This can allow the project using this package to store the key derivation options alongside the vault, allowing for easier migrations to newer derivation options in the future.Closes #1