Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huobi Echo Chain - Ledger - Metamask Issues : Metamask #10294

Closed
yonghoban opened this issue Jan 27, 2021 · 25 comments
Closed

Huobi Echo Chain - Ledger - Metamask Issues : Metamask #10294

yonghoban opened this issue Jan 27, 2021 · 25 comments
Assignees
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug Something isn't working

Comments

@yonghoban
Copy link

yonghoban commented Jan 27, 2021

add custom network
Network Name : heco-mainnet
New RPC URL : https://http-mainnet-node.huobichain.com
Chain ID : 128
Currency Symbol : HT
Block Explorer URL : https://scan.hecochain.com

Metamask account Ledger account having issues with HECO Transfers
I have a Ledger Nano S, successfully connected with MetaMask Wallet.
I have recently added Huobi Echo Chain to the Metamask Account, the same account as Ledger Metamask Account.
I can see the coins in the Metamask Ledger Account - Huobi Echo Chain.
If I initiate to transfer funds from Metmask Echo Chain, it is connecting to Ledger, and signature fails.

  • OS : Windows10
  • Browser : Chrom 88.0.4324.104 (64bit)
  • Ledger firm version : 1.6.1
  • Ledger ETH version : 1.6.4
  • "contract data" enabled on the Ledger (ETH app)

Legder_error

@Gudahtt Gudahtt added needs-triage type-bug Something isn't working labels Jan 27, 2021
@hoffer
Copy link

hoffer commented Feb 1, 2021

i have the same issue…… please help

@tmashuang
Copy link
Contributor

Does Ledger support the Huobi Echo Chain?

@yonghoban
Copy link
Author

Does Ledger support the Huobi Echo Chain?
No. but Meta mask supported HECO.

@danfinlay danfinlay added the Sev2-normal Normal severity; minor loss of service or inconvenience. label Feb 2, 2021
@Gudahtt
Copy link
Member

Gudahtt commented Feb 2, 2021

This is likely caused by MetaMask/eth-ledger-bridge-keyring#50; the Ledger library we're using right now doesn't support Chain IDs over 108.

@mudgen

This comment has been minimized.

@mudgen

This comment has been minimized.

@danfinlay
Copy link
Contributor

This is currently proposed for consideration in our next sprint, starting next week.

@mudgen

This comment has been minimized.

@hoffer

This comment has been minimized.

@mudgen

This comment has been minimized.

@Lollypopsie
Copy link

Lollypopsie commented Feb 5, 2021

It is actually possible to send funds to a wallet with ledger, thing is that once they arrive they are locked because of the bug, all actions fail. It would be really appreciated if the priority of this bug was increased. Thanks in advance.

@leonprou
Copy link

leonprou commented Feb 7, 2021

Our chainId is 122 (Fuse network), and we are experiencing the same behavior.

Digging into this we found out that this is related to this issue MetaMask/eth-ledger-bridge-keyring#50.
Looks like this is already fixed by the Ledger team.

@mudgen

This comment has been minimized.

@Andrew-Pohl
Copy link

@darkwing was this actually fixed? I saw that a fix was merged in the ledger keyring but it looks like the current metamask extension is still using the old keyring version

@Gudahtt
Copy link
Member

Gudahtt commented Feb 16, 2021

Yes, this should be fixed. The Ledger bridge keyring is in two parts: the keyring, and the bridge between the keyring and the Ledger device. The bridge is a website served from GitHub pages, so it gets deployed immediately when we merge something into the gh-pages branch. The change in question was to the bridge.

@Andrew-Pohl
Copy link

Yes, this should be fixed. The Ledger bridge keyring is in two parts: the keyring, and the bridge between the keyring and the Ledger device. The bridge is a website served from GitHub pages, so it gets deployed immediately when we merge something into the gh-pages branch. The change in question was to the bridge.

Ahh great thanks for the clarification will test it again on my end

@Andrew-Pohl
Copy link

@Gudahtt Not sure if I am missing something but sadly on Fuse (chain id 122) we are still having the same errors. Have tried on 2 PCs (one windows, one ubuntu) and tried on chrome and firefox both giving the same issue of invalid signature It signs fine with ledger using MEW so don't think it is an issue on our end.

Network details:
image

Should I open a new issue or can I "piggy back" off of this one?.

@Gudahtt
Copy link
Member

Gudahtt commented Feb 16, 2021

Thanks for checking @Andrew-Pohl ! We can use this issue, unless we determine the problem you're experiencing is a separate issue. I'll re-open this now.

@Gudahtt Gudahtt reopened this Feb 16, 2021
@darkwing
Copy link
Contributor

Thank you for the update @Andrew-Pohl! I was able too add Fuse to my local MetaMask, connected my Ledger Nano X, then went to https://metamask.github.io/test-dapp/ to test signing, which worked great. Is your issue specifically about sending FUSE tokens? Could you provide more detail in steps to reproduce, etc.? Thank you so much!

@Andrew-Pohl
Copy link

Andrew-Pohl commented Feb 16, 2021

Thank you for the update @Andrew-Pohl! I was able too add Fuse to my local MetaMask, connected my Ledger Nano X, then went to https://metamask.github.io/test-dapp/ to test signing, which worked great. Is your issue specifically about sending FUSE tokens? Could you provide more detail in steps to reproduce, etc.? Thank you so much!

Hi @darkwing, signing any transaction on fusenet using a ledger and metamask (be it sending native fuse, erc20 tokens on fuse, deploying contracts and so on) all seem to fail with the following error:

{
"op": "add",
"path": "/err",
"value": {
"message": "Error: Ledger: The transaction signature is not valid",
"stack": "Error: Ledger: The transaction signature is not valid\n at chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background.js:1:563428\n at r (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/background.js:1:565062)\n at c (chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/initSentry.js:1:10461)"
},
"note": "transactions:tx-state-manager#fail - add error",
"timestamp": 1613495442202
}

To reproduce:
• Launch metamask
• Switch to fusenet
• Connect to ledger
• Try to send fuse (or any transaction)

Happy to send you some fuse for you to test on your side?

Edit I'm testing on a nano S here (I have an X too so will give that a try also) - Edit2 just tested same result with nanoX

Tested using your test dapp and Eth sign works however Send Eth (fuse in this case), send tokens and deploy contract all fail with signature errors

@darkwing
Copy link
Contributor

I'm escalating this with @LedgerHQ as we've seen a few reports of this, and numerous via a Google search. Related:

LedgerHQ/ledger-nano-s#65

@darkwing
Copy link
Contributor

The @LedgerHQ team has posted LedgerHQ/ledgerjs#576

@FrederikBolding
Copy link
Member

The @LedgerHQ team has posted LedgerHQ/ledgerjs#576

Just to clarify, I don't work for Ledger. We had the bug reported by EWC users on MyCrypto and I submitted the issue (LedgerHQ/ledgerjs#575) and the PR to try and help them fix the issue on their end.

I wrote this as a workaround that we are currently using for MyCrypto.
https://github.com/MyCryptoHQ/MyCrypto/blob/57573908ae08f5097064b021cf3bc8a98e57d81a/src/services/WalletService/deterministic/ledger.ts#L75-L91

@numa-nalo
Copy link

🐲 On my hand I still can't send MATIC tokens from Ledger Nano S to Metamask on the Matic network... how come ?

@Andrew-Pohl
Copy link

@darkwing Great news the new ledger libraries seem to solve the problem. Thanks @FrederikBolding for spotting/fixing the issue and making the ledger guys aware :)

@darkwing darkwing closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev2-normal Normal severity; minor loss of service or inconvenience. type-bug Something isn't working
Projects
None yet
Development

No branches or pull requests