You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been poking around a little bit and one thing that jumps out to me is that the tsconfig.json options in front_end are (IMO) loose.
There are some easy wins to be had by for e.g. turning on noUnusedLocals - this would catch 50+ dead imports, orphan functions, etc, today -- increasing the quality of the codebase and ease of understanding for the future.
I thought I'd ask first before just firing off PRs about this though, because I know these things are always at least a bit subejctive and the comfort level / familiarity of the team matters a lot.
So: what's the appetite here? would PRs tightening up tsconfig options (and associated errors) be welcomed, 'welcomed but not right now', or are we happy with the strictness level as it stands today?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I've been poking around a little bit and one thing that jumps out to me is that the tsconfig.json options in front_end are (IMO) loose.
There are some easy wins to be had by for e.g. turning on noUnusedLocals - this would catch 50+ dead imports, orphan functions, etc, today -- increasing the quality of the codebase and ease of understanding for the future.
I thought I'd ask first before just firing off PRs about this though, because I know these things are always at least a bit subejctive and the comfort level / familiarity of the team matters a lot.
So: what's the appetite here? would PRs tightening up tsconfig options (and associated errors) be welcomed, 'welcomed but not right now', or are we happy with the strictness level as it stands today?
Beta Was this translation helpful? Give feedback.
All reactions