You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I recommend introducing a settings.yaml file for constants that users (builders) don't need to modify. Currently, our jukebox.yaml combines both user-relevant settings and constants. One might wonder why these constants aren't simply coded into the software, but occasionally, even these constants need adjustments, such as during development.
In our existing jukebox.default.yaml, there are many details that aren't relevant to the builder, and altering them could impair the system's functionality.
My suggestion involves adopting an approach similar to Docker Compose yaml files, where settings.yaml serves as the base and jukebox.yaml acts as an override.
Benefits would be:
Reduced jukebox.yaml creating less confusion for users/builders.
Better configurability for developers
Here are several sections that could be separated out (as the comments also advise against modifying).
modules:
named:
# Do not change the order!publishing: publishingvolume: volumejingle: jinglejingle.alsawave: jingle.alsawavejingle.jinglemp3: jingle.jinglemp3player: playermpdcards: rfid.cardsrfid: rfid.readertimers: timershost: hostif.linuxbluetooth_audio_buttons: controls.bluetooth_audio_buttonsgpio: gpio.gpioz.pluginsync_rfidcards: synchronisation.rfidcardsothers:
- misc
rpc:
tcp_port: 5555websocket_port: 5556publishing:
# Ports for the publisher. Setting a port number to 0 disables the port# The WebUI requires the websocket connectiontcp_port: 5558websocket_port: 5557rfid:
reader_config: ../../shared/settings/rfid.yamlcard_database: ../../shared/settings/cards.yaml
I think it's a good idea.
Only suggestion for clarity: call the file with the non changing parameters constants.yaml, base.yaml or default.yaml (or something else, you get the idea).
I think settings sounds like the users should change something here.
Feature
I recommend introducing a
settings.yaml
file for constants that users (builders) don't need to modify. Currently, ourjukebox.yaml
combines both user-relevant settings and constants. One might wonder why these constants aren't simply coded into the software, but occasionally, even these constants need adjustments, such as during development.In our existing
jukebox.default.yaml
, there are many details that aren't relevant to the builder, and altering them could impair the system's functionality.My suggestion involves adopting an approach similar to Docker Compose yaml files, where
settings.yaml
serves as the base andjukebox.yaml
acts as an override.Benefits would be:
jukebox.yaml
creating less confusion for users/builders.Here are several sections that could be separated out (as the comments also advise against modifying).
The text was updated successfully, but these errors were encountered: