Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect implementation: Check stops at the first of several includes if there is an error. #31

Open
PATROMO opened this issue May 14, 2019 · 1 comment
Open

Incorrect implementation: Check stops at the first of several includes if there is an error. #31

PATROMO opened this issue May 14, 2019 · 1 comment

Comments

@PATROMO
Copy link

PATROMO commented May 14, 2019

The check process stops at the first of several includes if there is an error.
This is incorrect implemented see: https://tools.ietf.org/html/rfc7208#section-5.2
@bokanechase-digistorm
Copy link

This is something I've seen too. We had an SPF record with one include pointing to a domain that was missing an SPF record. This resulted in a Result::NONE for that IncludeEvaluator which then throws a PermErrorException and then SPFCheck returns early without evaluating any of the other includes / records.

This seems inconsistent with the behaviour of the RFC and what services like https://easydmarc.com/ were reporting.

Excellent library otherwise 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PATROMO @bokanechase-digistorm