Merge pull request #249 from MindscapeHQ/remove-breadcrumbs-error-rep…

…orting Remove breadcrumbs error reporting
MindscapeHQ · Sep 5, 2017 · 7338180 · 7338180
2 parents 471031a + 9e10d3b
commit 7338180
Show file tree

Hide file tree

Showing 15 changed files with 53 additions and 85 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "raygun4js",
-  "version": "2.7.1",
+  "version": "2.7.2",
   "homepage": "http://raygun.io",
   "authors": [
     "Mindscape <[email protected]>"

diff --git a/dist/raygun.js b/dist/raygun.js
@@ -1,4 +1,4 @@
-/*! Raygun4js - v2.7.1 - 2017-07-21
+/*! Raygun4js - v2.7.2 - 2017-08-15
 * https://github.com/MindscapeHQ/raygun4js
 * Copyright (c) 2017 MindscapeHQ; Licensed MIT */
 (function(window, undefined) {
@@ -1668,7 +1668,7 @@ window.raygunUtilityFactory = function (window, Raygun) {
           }
         };
 
-        return function unhenance() {
+        return function unenhance() {
           object[property] = existingFunction;
         };
       },
@@ -1769,14 +1769,12 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
         this.logXhrContents = false;
         this.xhrIgnoredHosts = [].concat(this.DEFAULT_XHR_IGNORED_HOSTS);
         this.breadcrumbs = [];
-        this.raygunInstance = {send: function() {}};
-        var self = this;
         this.wrapWithHandler = function(method) {
             return function() {
                 try {
                     return method.apply(this, arguments);
                 } catch (ex) {
-                    self.raygunInstance.send(ex);
+                    Raygun.Utilities.log(ex);
                 }
             };
         };
@@ -1787,6 +1785,7 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
         this.disableClicksTracking = function() {};
 
         this.enableAutoBreadcrumbs();
+        this.wrapPrototypeWithHandlers();
     };
 
     Breadcrumbs.prototype.recordBreadcrumb = function(value, metadata) {
@@ -2174,10 +2173,7 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
     };
 
 
-    Breadcrumbs.prototype.setCrashReportingInstance = function(raygunInstance) {
-        raygunInstance.init('D8pC4YA3glwX5g4N/krb6Q==');
-        this.raygunInstance = raygunInstance;
-
+    Breadcrumbs.prototype.wrapPrototypeWithHandlers = function() {
         var name, method;
         for(name in Breadcrumbs.prototype) {
             method = Breadcrumbs.prototype[name];
@@ -2192,7 +2188,7 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
 
 /*globals __DEV__, raygunUtilityFactory, raygunBreadcrumbsFactory */
 
-var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
+var raygunFactory = function (window, $, undefined) {
     var Raygun = {};
     Raygun.Utilities = raygunUtilityFactory(window, Raygun);
     Raygun.Breadcrumbs = raygunBreadcrumbsFactory(window, Raygun);
@@ -2259,8 +2255,8 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
             return Raygun;
         },
 
-        constructNewRaygun: function (forBreadcrumbs) {
-            var rgInstance = raygunFactory(window, window.jQuery, forBreadcrumbs);
+        constructNewRaygun: function () {
+            var rgInstance = raygunFactory(window, window.jQuery);
 
             return rgInstance;
         },
@@ -2317,10 +2313,6 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
                 }
             }
 
-           if (!forBreadcrumbs) {
-               _breadcrumbs.setCrashReportingInstance(this.constructNewRaygun(true));
-           }
-
             ensureUser();
 
             return Raygun;
@@ -2959,7 +2951,7 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
                 },
                 'Client': {
                     'Name': 'raygun-js',
-                    'Version': '2.7.1'
+                    'Version': '2.7.2'
                 },
                 'UserCustomData': finalCustomData,
                 'Tags': options.tags,
@@ -3116,7 +3108,7 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
         xhr.send(data);
     }
 
-    if (!window.__raygunNoConflict && !forBreadcrumbs) {
+    if (!window.__raygunNoConflict) {
       window.Raygun = Raygun;
     }
     TraceKit.setRaygun(Raygun);

diff --git a/dist/raygun.min.js b/dist/raygun.min.js
diff --git a/dist/raygun.min.js.map b/dist/raygun.min.js.map
diff --git a/dist/raygun.umd.js b/dist/raygun.umd.js
@@ -1,4 +1,4 @@
-/*! Raygun4js - v2.7.1 - 2017-07-21
+/*! Raygun4js - v2.7.2 - 2017-08-15
 * https://github.com/MindscapeHQ/raygun4js
 * Copyright (c) 2017 MindscapeHQ; Licensed MIT */
 // https://github.com/umdjs/umd/blob/master/templates/returnExportsGlobal.js
@@ -1703,7 +1703,7 @@ window.raygunUtilityFactory = function (window, Raygun) {
           }
         };
 
-        return function unhenance() {
+        return function unenhance() {
           object[property] = existingFunction;
         };
       },
@@ -1804,14 +1804,12 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
         this.logXhrContents = false;
         this.xhrIgnoredHosts = [].concat(this.DEFAULT_XHR_IGNORED_HOSTS);
         this.breadcrumbs = [];
-        this.raygunInstance = {send: function() {}};
-        var self = this;
         this.wrapWithHandler = function(method) {
             return function() {
                 try {
                     return method.apply(this, arguments);
                 } catch (ex) {
-                    self.raygunInstance.send(ex);
+                    Raygun.Utilities.log(ex);
                 }
             };
         };
@@ -1822,6 +1820,7 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
         this.disableClicksTracking = function() {};
 
         this.enableAutoBreadcrumbs();
+        this.wrapPrototypeWithHandlers();
     };
 
     Breadcrumbs.prototype.recordBreadcrumb = function(value, metadata) {
@@ -2209,10 +2208,7 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
     };
 
 
-    Breadcrumbs.prototype.setCrashReportingInstance = function(raygunInstance) {
-        raygunInstance.init('D8pC4YA3glwX5g4N/krb6Q==');
-        this.raygunInstance = raygunInstance;
-
+    Breadcrumbs.prototype.wrapPrototypeWithHandlers = function() {
         var name, method;
         for(name in Breadcrumbs.prototype) {
             method = Breadcrumbs.prototype[name];
@@ -2227,7 +2223,7 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
 
 /*globals __DEV__, raygunUtilityFactory, raygunBreadcrumbsFactory */
 
-var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
+var raygunFactory = function (window, $, undefined) {
     var Raygun = {};
     Raygun.Utilities = raygunUtilityFactory(window, Raygun);
     Raygun.Breadcrumbs = raygunBreadcrumbsFactory(window, Raygun);
@@ -2294,8 +2290,8 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
             return Raygun;
         },
 
-        constructNewRaygun: function (forBreadcrumbs) {
-            var rgInstance = raygunFactory(window, window.jQuery, forBreadcrumbs);
+        constructNewRaygun: function () {
+            var rgInstance = raygunFactory(window, window.jQuery);
 
             return rgInstance;
         },
@@ -2352,10 +2348,6 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
                 }
             }
 
-           if (!forBreadcrumbs) {
-               _breadcrumbs.setCrashReportingInstance(this.constructNewRaygun(true));
-           }
-
             ensureUser();
 
             return Raygun;
@@ -2994,7 +2986,7 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
                 },
                 'Client': {
                     'Name': 'raygun-js',
-                    'Version': '2.7.1'
+                    'Version': '2.7.2'
                 },
                 'UserCustomData': finalCustomData,
                 'Tags': options.tags,
@@ -3151,7 +3143,7 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
         xhr.send(data);
     }
 
-    if (!window.__raygunNoConflict && !forBreadcrumbs) {
+    if (!window.__raygunNoConflict) {
       window.Raygun = Raygun;
     }
     TraceKit.setRaygun(Raygun);

diff --git a/dist/raygun.umd.min.js b/dist/raygun.umd.min.js
diff --git a/dist/raygun.umd.min.js.map b/dist/raygun.umd.min.js.map
diff --git a/dist/raygun.vanilla.js b/dist/raygun.vanilla.js
@@ -1,4 +1,4 @@
-/*! Raygun4js - v2.7.1 - 2017-07-21
+/*! Raygun4js - v2.7.2 - 2017-08-15
 * https://github.com/MindscapeHQ/raygun4js
 * Copyright (c) 2017 MindscapeHQ; Licensed MIT */
 (function(window, undefined) {
@@ -1600,7 +1600,7 @@ window.raygunUtilityFactory = function (window, Raygun) {
           }
         };
 
-        return function unhenance() {
+        return function unenhance() {
           object[property] = existingFunction;
         };
       },
@@ -1701,14 +1701,12 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
         this.logXhrContents = false;
         this.xhrIgnoredHosts = [].concat(this.DEFAULT_XHR_IGNORED_HOSTS);
         this.breadcrumbs = [];
-        this.raygunInstance = {send: function() {}};
-        var self = this;
         this.wrapWithHandler = function(method) {
             return function() {
                 try {
                     return method.apply(this, arguments);
                 } catch (ex) {
-                    self.raygunInstance.send(ex);
+                    Raygun.Utilities.log(ex);
                 }
             };
         };
@@ -1719,6 +1717,7 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
         this.disableClicksTracking = function() {};
 
         this.enableAutoBreadcrumbs();
+        this.wrapPrototypeWithHandlers();
     };
 
     Breadcrumbs.prototype.recordBreadcrumb = function(value, metadata) {
@@ -2106,10 +2105,7 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
     };
 
 
-    Breadcrumbs.prototype.setCrashReportingInstance = function(raygunInstance) {
-        raygunInstance.init('D8pC4YA3glwX5g4N/krb6Q==');
-        this.raygunInstance = raygunInstance;
-
+    Breadcrumbs.prototype.wrapPrototypeWithHandlers = function() {
         var name, method;
         for(name in Breadcrumbs.prototype) {
             method = Breadcrumbs.prototype[name];
@@ -2124,7 +2120,7 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
 
 /*globals __DEV__, raygunUtilityFactory, raygunBreadcrumbsFactory */
 
-var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
+var raygunFactory = function (window, $, undefined) {
     var Raygun = {};
     Raygun.Utilities = raygunUtilityFactory(window, Raygun);
     Raygun.Breadcrumbs = raygunBreadcrumbsFactory(window, Raygun);
@@ -2191,8 +2187,8 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
             return Raygun;
         },
 
-        constructNewRaygun: function (forBreadcrumbs) {
-            var rgInstance = raygunFactory(window, window.jQuery, forBreadcrumbs);
+        constructNewRaygun: function () {
+            var rgInstance = raygunFactory(window, window.jQuery);
 
             return rgInstance;
         },
@@ -2249,10 +2245,6 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
                 }
             }
 
-           if (!forBreadcrumbs) {
-               _breadcrumbs.setCrashReportingInstance(this.constructNewRaygun(true));
-           }
-
             ensureUser();
 
             return Raygun;
@@ -2891,7 +2883,7 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
                 },
                 'Client': {
                     'Name': 'raygun-js',
-                    'Version': '2.7.1'
+                    'Version': '2.7.2'
                 },
                 'UserCustomData': finalCustomData,
                 'Tags': options.tags,
@@ -3048,7 +3040,7 @@ var raygunFactory = function (window, $, forBreadcrumbs, undefined) {
         xhr.send(data);
     }
 
-    if (!window.__raygunNoConflict && !forBreadcrumbs) {
+    if (!window.__raygunNoConflict) {
       window.Raygun = Raygun;
     }
     TraceKit.setRaygun(Raygun);

diff --git a/dist/raygun.vanilla.min.js b/dist/raygun.vanilla.min.js
diff --git a/dist/raygun.vanilla.min.js.map b/dist/raygun.vanilla.min.js.map
diff --git a/package.json b/package.json
@@ -3,7 +3,7 @@
   "main": "dist/raygun.umd.js",
   "title": "Raygun4js",
   "description": "Raygun.io plugin for JavaScript",
-  "version": "2.7.1",
+  "version": "2.7.2",
   "homepage": "https://github.com/MindscapeHQ/raygun4js",
   "author": {
     "name": "MindscapeHQ",

diff --git a/raygun4js.nuspec b/raygun4js.nuspec
@@ -2,7 +2,7 @@
 <package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
   <metadata>
     <id>raygun4js</id>
-    <version>2.7.1</version>
+    <version>2.7.2</version>
     <title>Raygun4js</title>
     <authors>Mindscape Limited</authors>
     <owners>Mindscape Limited</owners>

diff --git a/src/raygun.breadcrumbs.js b/src/raygun.breadcrumbs.js
@@ -33,14 +33,12 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
         this.logXhrContents = false;
         this.xhrIgnoredHosts = [].concat(this.DEFAULT_XHR_IGNORED_HOSTS);
         this.breadcrumbs = [];
-        this.raygunInstance = {send: function() {}};
-        var self = this;
         this.wrapWithHandler = function(method) {
             return function() {
                 try {
                     return method.apply(this, arguments);
                 } catch (ex) {
-                    self.raygunInstance.send(ex);
+                    Raygun.Utilities.log(ex);
                 }
             };
         };
@@ -51,6 +49,7 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
         this.disableClicksTracking = function() {};
 
         this.enableAutoBreadcrumbs();
+        this.wrapPrototypeWithHandlers();
     };
 
     Breadcrumbs.prototype.recordBreadcrumb = function(value, metadata) {
@@ -438,10 +437,7 @@ window.raygunBreadcrumbsFactory = function(window, Raygun) {
     };
 
 
-    Breadcrumbs.prototype.setCrashReportingInstance = function(raygunInstance) {
-        raygunInstance.init('D8pC4YA3glwX5g4N/krb6Q==');
-        this.raygunInstance = raygunInstance;
-
+    Breadcrumbs.prototype.wrapPrototypeWithHandlers = function() {
         var name, method;
         for(name in Breadcrumbs.prototype) {
             method = Breadcrumbs.prototype[name];