Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with ToMeTinkers #82

Open
ToMe25 opened this issue Sep 11, 2020 · 1 comment
Open

Crash with ToMeTinkers #82

ToMe25 opened this issue Sep 11, 2020 · 1 comment

Comments

@ToMe25
Copy link

ToMe25 commented Sep 11, 2020

Someone reported to me that using Armory-Expansion(1.4.2), Extra Utilities 2(1.9.9), and ToMeTinkers(1.2.3) causes this crash, which i could reliably reproduce.
This seems to be caused by two mods trying to add traits to the same material for the same armor parts.
Because ToMeTinkers adds a modified version of the XU2 traits that actually works on armor, while Armory Expansion doesn't i would suggest disabling Armory Expansions support if both mods are loaded.
I think there would be two ways to fix this:

  • ToMeTinkers could disable the Armory Expansion support(I haven't found a way to do this yet, but it should be possible), or
  • Armory expansion could check whether a material is already registered for armor parts before trying to register the material(i think this would be the better solution)
@YaibaToKen
Copy link
Collaborator

That's a major error on my part. I forgot to check if the trait is already registered to the material before trying to do so.
I do already check if an armor part is registered before trying to register said part, but since traits are added on a different section, there's no way to check if the armor part was added by me or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants