Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize settings so that each module get their own page #62

Closed
Samuel12321 opened this issue Sep 28, 2020 · 36 comments
Closed

Reorganize settings so that each module get their own page #62

Samuel12321 opened this issue Sep 28, 2020 · 36 comments
Assignees
Labels
Enhancement New feature or request UI/UX Related to appearance of the app and flyout.

Comments

@Samuel12321
Copy link
Member

We need to reorganize settings so that each module get their own page (if they need multiple options e.g. Audio) or a fused page (e.g. Brightness and airplane)

@Samuel12321 Samuel12321 added Enhancement New feature or request UI/UX Related to appearance of the app and flyout. labels Sep 28, 2020
@Samuel12321 Samuel12321 added this to the 0.8 milestone Sep 28, 2020
@Samuel12321
Copy link
Member Author

#43

@ShankarBUS
Copy link
Member

Thanks @Samuel12321!

@ShankarBUS ShankarBUS self-assigned this Sep 28, 2020
@ShankarBUS ShankarBUS removed this from the 0.8 milestone Oct 11, 2020
@prakharb5
Copy link
Member

prakharb5 commented Oct 20, 2020

Do also add a design and layout page too! For transparency, position etc.

@ShankarBUS
Copy link
Member

Shouldn't they be in the UI page?

I seriously don't have any idea what to do 😅.

Could you both help me with this?

@prakharb5
Copy link
Member

prakharb5 commented Oct 21, 2020

What pages do you have in mind?

I am thinking of General, Design and Layout, Modules

@ShankarBUS
Copy link
Member

Sounds good!

@Samuel12321
Copy link
Member Author

👍

@ShankarBUS
Copy link
Member

@Cyberdroid1,

How about this?

  • General
  • UI (or User Interface or Personalization)
  • Modules
    • Audio
    • Brightness
    • Airplane mode
    • Lock keys

Design and Layout doesn't sound that great 😅. Design would be good, no problems with that. But for now, we don't have anything to consider as a setting for changing the layout.

Could we start a discussion?

@prakharb5
Copy link
Member

prakharb5 commented Oct 22, 2020

Let's call it Design and Interface. No need to create separate page for each module for now.

But then, design and interface both mean same. 😂

@ShankarBUS
Copy link
Member

No need to create separate page for each module for now.

We have to, each module may get new features in the future.

It's better to have separate pages.

We won't have much time to split the pages in the future.

The pages may be empty for now.

But it's better make them now.

No one mind if there are 10 options or 2 options on a settings page.

PowerToys have separate pages for each toys even though some of them have very few options.

If we have empty pages, we will have the motive to fill them later.

But if they are cluttered on a single page, we would feel lazy to reorg them again.

@Samuel12321, would you like to say anything?

@prakharb5
Copy link
Member

Hmm, you have a good point. I support ya!

@Samuel12321
Copy link
Member Author

i agree

@ShankarBUS
Copy link
Member

How about this bros?

image

@ShankarBUS
Copy link
Member

@Cyberdroid1, @Samuel12321,

Could you guys answer quickly? I'm waiting for your feedback

@Samuel12321
Copy link
Member Author

Looks amazing

@Samuel12321
Copy link
Member Author

is it a mock-up, or programmed?

@prakharb5
Copy link
Member

prakharb5 commented Oct 24, 2020

Looks good to me!

What is there in personalization?

@stlnb
Copy link
Contributor

stlnb commented Oct 24, 2020

Seems great

@ShankarBUS
Copy link
Member

Sorry for the delay guys

is it a mock-up, or programmed?

It is not a mockup. I added empty pages to the real app to experiment with them before the actual implementation.

What is there in personalization?

Nothing for now, all the pages are empty (except General and About pages).

Every thing related to UI or UX or layout will go into it.

@prakharb5
Copy link
Member

Can we rename the page Audio to Audio and Media ?

Because it would contain settings for media flyout also, right?

@ShankarBUS
Copy link
Member

ShankarBUS commented Oct 28, 2020

@Cyberdroid1, I'm still prototyping the settings window.

That's a nice suggestion 😄.

Edit: Wouldn't "Media" also include "Audio" by it's definition?

@prakharb5
Copy link
Member

prakharb5 commented Oct 28, 2020

Wait wait, let's name it Media and Volume

@prakharb5
Copy link
Member

Because Media will contain videos and audios. Volume is a separate thing from both.

@ShankarBUS
Copy link
Member

ShankarBUS commented Oct 31, 2020

Hey guys my system shows Flight mode instead of Airplane mode everywhere when I switch from English (United States) to English (India) on Windows settings.

Is the term different for each language?

@Samuel12321
Copy link
Member Author

i think the two are used interchangeably "Airplane mode" is probably American, every where else uses "flight mode"

@prakharb5
Copy link
Member

prakharb5 commented Oct 31, 2020

Well, it's machine language.
You can't expect much.

@prakharb5
Copy link
Member

prakharb5 commented Oct 31, 2020

It can also be like, that
The machine translation first converts the input the words to some standard language, and then use the words in that language to other languages.

Maybe...

@ShankarBUS
Copy link
Member

ShankarBUS commented Oct 31, 2020

@Cyberdroid1,

It can also be like, that
The machine translation first converts the input the words to some standard language, and then use the words in that language to other languages.

Maybe...

I was referring to the legacy flyout and Windows system (Tray Network flyout, Windows Settings & etc.). Only Windows inbuilt things show "Flight mode" not ModernFlyouts. ModernFlyouts still shows "Airplane mode".

Our behaviour is different from Windows. What should we do?

Wait wait, let's name it Media and Volume

The term Audio flyout is used commonly all over the repo & even in the app's code. It became more like a brand for that module. Changing it now would be confusing. Let's re-consider this in the future.

However, we can introduce sub modules (new sub items in the navigation view) with the names Volume & Media. Any objections?

@ShankarBUS
Copy link
Member

@Cyberdroid1,

image

Like this maybe?

@prakharb5
Copy link
Member

Why complicate this simple stuff by creating extra options?

@prakharb5
Copy link
Member

prakharb5 commented Oct 31, 2020

Let's keep it just Audio then.

I don't think there would be so many settings in media and volume flyout that we need to separate the both.

@ShankarBUS
Copy link
Member

I'm not creating separate pages for the sub modules! 🤦‍♂️

I'm just providing a way to navigate to the tabs within the page

image
image

I don't think there would be so many settings in media and volume flyout that we need to separate the both.

That's what I thought in the past. Look now where we are! We can't believe there won't be any new features in the future.
They may grow in size in the future if #148, #114, #103 and #78 are implemented. That's why I split them into multiple tabs.

Why complicate this simple stuff by creating extra options?

But they are all in a single page. So, there are won't be any complications, I guess?

@prakharb5
Copy link
Member

image

I did not see this one. This looks amazing!

@prakharb5
Copy link
Member

I'm not creating separate pages for the sub modules! 🤦‍♂️

I'm just providing a way to navigate to the tabs within the page

Don't add that option, please.

@ShankarBUS
Copy link
Member

Don't add that option, please.

I'm not adding it TBH. It's just a mock-up and I just asked for an opinion. It's not easy BTW.

@ShankarBUS
Copy link
Member

Implemented in 2dd9139.

I hope I didn't disappoint any of you 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request UI/UX Related to appearance of the app and flyout.
Projects
None yet
Development

No branches or pull requests

4 participants