-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize settings so that each module get their own page #62
Comments
Thanks @Samuel12321! |
Do also add a design and layout page too! For transparency, position etc. |
Shouldn't they be in the UI page? I seriously don't have any idea what to do 😅. Could you both help me with this? |
What pages do you have in mind? I am thinking of General, Design and Layout, Modules |
Sounds good! |
👍 |
@Cyberdroid1, How about this?
Design and Layout doesn't sound that great 😅. Design would be good, no problems with that. But for now, we don't have anything to consider as a setting for changing the layout. Could we start a discussion? |
Let's call it Design and Interface. No need to create separate page for each module for now. But then, design and interface both mean same. 😂 |
We have to, each module may get new features in the future. It's better to have separate pages. We won't have much time to split the pages in the future. The pages may be empty for now. But it's better make them now. No one mind if there are 10 options or 2 options on a settings page. PowerToys have separate pages for each toys even though some of them have very few options. If we have empty pages, we will have the motive to fill them later. But if they are cluttered on a single page, we would feel lazy to reorg them again. @Samuel12321, would you like to say anything? |
Hmm, you have a good point. I support ya! |
i agree |
@Cyberdroid1, @Samuel12321, Could you guys answer quickly? I'm waiting for your feedback |
Looks amazing |
is it a mock-up, or programmed? |
Looks good to me! What is there in personalization? |
Seems great |
Sorry for the delay guys
It is not a mockup. I added empty pages to the real app to experiment with them before the actual implementation.
Nothing for now, all the pages are empty (except General and About pages). Every thing related to UI or UX or layout will go into it. |
Can we rename the page Because it would contain settings for media flyout also, right? |
@Cyberdroid1, I'm still prototyping the settings window. That's a nice suggestion 😄. Edit: Wouldn't "Media" also include "Audio" by it's definition? |
Wait wait, let's name it |
Because Media will contain videos and audios. Volume is a separate thing from both. |
Hey guys my system shows Is the term different for each language? |
i think the two are used interchangeably "Airplane mode" is probably American, every where else uses "flight mode" |
Well, it's machine language. |
It can also be like, that Maybe... |
@Cyberdroid1,
I was referring to the legacy flyout and Windows system (Tray Network flyout, Windows Settings & etc.). Only Windows inbuilt things show "Flight mode" not ModernFlyouts. ModernFlyouts still shows "Airplane mode". Our behaviour is different from Windows. What should we do?
The term Audio flyout is used commonly all over the repo & even in the app's code. It became more like a brand for that module. Changing it now would be confusing. Let's re-consider this in the future. However, we can introduce sub modules (new sub items in the navigation view) with the names |
Why complicate this simple stuff by creating extra options? |
Let's keep it just Audio then. I don't think there would be so many settings in media and volume flyout that we need to separate the both. |
I'm not creating separate pages for the sub modules! 🤦♂️ I'm just providing a way to navigate to the tabs within the page
That's what I thought in the past. Look now where we are! We can't believe there won't be any new features in the future.
But they are all in a single page. So, there are won't be any complications, I guess? |
Don't add that option, please. |
I'm not adding it TBH. It's just a mock-up and I just asked for an opinion. It's not easy BTW. |
Implemented in 2dd9139. I hope I didn't disappoint any of you 😅. |
The text was updated successfully, but these errors were encountered: