From 7ceeeefddbd085beb3e2dbacc0e8d1ede9561016 Mon Sep 17 00:00:00 2001 From: Arseny Garelyshev Date: Sun, 2 Feb 2025 12:50:02 +0100 Subject: [PATCH] fix: don't throw if loading youtube script fails Not all campaigns use and require youtube to operate. If youtube is blocked in your country, this will fail to load, killing the startup. To avoid that, we just console error the failure instead. This should probably resolve all those failed to load youtube duplicates. Refs: #2637 (and others) --- Startup.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Startup.js b/Startup.js index 09fa0f7ba..5f6596a3f 100644 --- a/Startup.js +++ b/Startup.js @@ -358,11 +358,13 @@ function load_external_script(scriptUrl) { return new Promise(function (resolve, reject) { let script = document.createElement('script'); script.src = scriptUrl; - script.addEventListener('error', function () { - reject(console.warn(`Failed to load external script ${scriptUrl}`)); + script.addEventListener('error', err => { + reject(err); }); script.addEventListener('load', resolve); document.head.appendChild(script); + }).catch((err) => { + console.error(`Failed to load external script`, scriptUrl, err); }) }