Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - New Year needs Update - No Popups #103

Closed
Bentic77 opened this issue Jan 1, 2022 · 17 comments
Closed

[BUG] - New Year needs Update - No Popups #103

Bentic77 opened this issue Jan 1, 2022 · 17 comments
Assignees
Labels
bug Something isn't working

Comments

@Bentic77
Copy link

Bentic77 commented Jan 1, 2022

Like always mercury trade needs a new year update. No popups for incoming trades.

@Bentic77 Bentic77 added the bug Something isn't working label Jan 1, 2022
@nick3hh
Copy link

nick3hh commented Jan 1, 2022

wonder what makes this break in the code

@Bentic77
Copy link
Author

Bentic77 commented Jan 1, 2022

wonder what makes this break in the code

afaik some certificate needs to be renewed

@nick3hh
Copy link

nick3hh commented Jan 2, 2022

wonder what makes this break in the code

afaik some certificate needs to be renewed

In case it doesnt get fixed, i just tried Poe Trades Companion, works just like mercury, its really good

@Rhaxis
Copy link

Rhaxis commented Jan 5, 2022

Any news on this? Would love to continue using mercury trade.

@tenesto
Copy link

tenesto commented Jan 5, 2022

wonder what makes this break in the code

afaik some certificate needs to be renewed

In case it doesnt get fixed, i just tried Poe Trades Companion, works just like mercury, its really good

Poe Trades Companion is AutoHotKey, isnt it?
if its realy a certificate, what takes so long to refresh it? ^^
so i guess the app is not supported anymore?! that would be realy sad...

@Morph21
Copy link
Owner

Morph21 commented Jan 5, 2022

It's not a problem with any certificate since this app does not have any certificate at all. The problem is that I can't replicate that error when I try so it's hard to fix it

@Morph21
Copy link
Owner

Morph21 commented Jan 5, 2022

When you press test message button do the popups show or not?

@Bentic77
Copy link
Author

Bentic77 commented Jan 5, 2022

Test shows up.

It was the same issue like 1. Jan 2019 in the original version.
Exslims#335

If you change your system Date back to 2021 it is working for incoming messages.

@tenesto
Copy link

tenesto commented Jan 5, 2022

i can use all "tests" and they popup/work...

@Bentic77
Copy link
Author

Bentic77 commented Jan 5, 2022

and same here 1. jan 2020
Exslims#404

@tenesto
Copy link

tenesto commented Jan 5, 2022

its very interesting how such a "new year bug" can still happen ^^
is the year a static number or what happend?
whats the background of this error? im realy curious...
im using poe-overlay-community-fork and it still works without a new-year-update.

@Morph21
Copy link
Owner

Morph21 commented Jan 5, 2022

I'm just looking at code, and yes, there is some static value for year checked for messages, I will fix it in a sec and try to deploy today

@Bentic77
Copy link
Author

Bentic77 commented Jan 5, 2022

I'm just looking at code, and yes, there is some static value for year checked for messages, I will fix it in a sec and try to deploy today

Sounds very good. The exact new year date got me to the assumption that it could be a certificate. so i think the issue is who it reads the date of the client.txt?

Thanks for your work.

@Morph21 Morph21 self-assigned this Jan 5, 2022
@create-issue-branch
Copy link

Branch issue-103-BUG-New_Year_needs_Update-_No_Popups created!

@Morph21
Copy link
Owner

Morph21 commented Jan 5, 2022

closed with release 1.1.8

@Morph21 Morph21 closed this as completed Jan 5, 2022
@Bentic77
Copy link
Author

Bentic77 commented Jan 5, 2022

Is this now fixxed for other years to come?
thx

@Morph21
Copy link
Owner

Morph21 commented Jan 5, 2022

@Bentic77 It's fixed up to 2099 so I think we are all covered :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants