Update permissions dialog UI design

[keianhzo]

Hardware

All

Steps to Reproduce

Current Behavior

The current permissions dialog UI is quite old and not matching the current app theme.

Expected Behavior

Update the permissions dialog UI to match the rest of the app UI. This includes:

1. New dialog Spec
2. Icon for file access permission. This is what Android system is currently using for file read access request:

Possible Solution

Context

Error Logs and Stack Traces

[MortimerGoro]

@thenadj If we are going to update the permission UI I have some feedback that I found while using the product:

When I visit some pages normally I don't care about the permissions (e.g. a lot of webs ask for a localization permission, but I'm not interested unless it's a map or something very specific). This causes the modal permission dialog to interrupt the browsing experience. I compare it with a full-screen interstitial that I need to close to continue browsing when I'm not interested in the permissions. If you see the permission prompt in Oculus Go, it's just a small box that doesn't interrupt the browsing and I think that it even autohides if you don't click on it.

IMO doing something like that would be more practical

[MortimerGoro]

Related it can be interesting to add an option to grant a permission permanently to a website, but in that case we also need some UI in settings to manage the granted permissions and allow the users to revoke them.

[keianhzo]

@MortimerGoro Agree with the above but what happens with app permissions like storage access? The user needs to grant/reject so the page can load/show error. At the moment we are blocking the page load until we get a response from the user.

[MortimerGoro]

@keianhzo that's an internal permission, not asked by the web, right? I guess we can handle that one in a different way

[keianhzo]

So web permissions in a non disruptive way and app permissions with a dialog, that could work.

[avrignaud]

@keianhzo @MortimerGoro @cvan Can you share a list of the common web page permissions we need to handle? Off the top of my head, I remember: location, microphone, video. Are there others? Also, be helpful to give a suggested page or two that fires off the web page permission ask so @thenadj can take a look at it in OB on the Go. I'd imagine the final permissions dialog might be pretty similar for both web pages and app permissions - but would need to make sure the distinction is clear.

Also, I think this permissions model suggests that we might need a "remember this choice" option, so the user isn't bothered in future. And that, in turn, suggests we need yet another setting/pane where the user can manage those permissions later (since they won't be prompted by the page later, or they might want to change global status for device permission). Does that sound about right?

[thenadj]

Attached is an updated UIS for dialogs. Based on the feedback above we'll look into it further and will upload a new design once it's read. Just adding this for in progress status reporting.
DE-31 Dialogs_001.pdf

[keianhzo]

@avrignaud @thenadj Current permissions are:

• Web

  • Camera
  • Microphone
  • CameraAndMicrophone
  • Location
  • Notification

• App

  • ReadExternalStorage

We are currently showing all of them as dialogs:

What @MortimerGoro was referring to as non-disrupting permissions view is what Oculus does:

Oculus never shows app permissions dialogs. I think it has all the permissions already granted as it's a stock app. Samsung Internet asks for permissions when the app is first launched and if you don't grant them you can't use the app, it just closes.

For app related permission showing a dialog like we have now I think it's fine.

[keianhzo]

@thenadj we also need an icon for the external storage read access permission (see #612 (comment) for details)

[jenniferhoang]

@keianhzo please see attached!
Permissions - External Storage Read Access.zip

[jenniferhoang]

@keianhzo @avrignaud Please see all attached UI Specs for updated UI design for dialogs.

---

Please note the button changes, we took out all of the outlines b/c they don't render well. We also updated the divider lines to Rhino @ 1pt.
UIS-16 Settings_014.pdf

---

We updated the buttons. No more outlines. The suggested button will be bright blue colored (Azure). Please note the 20px rounded corner change!

UIS-37 User Prompt for Crash Reporting_003.pdf

UIS-25-Permissions Dialogs 004.pdf

UIS-60 Speech&Voice Input Permissions_002.pdf

---

Please see changes to exit button. In order to have consistency with the Dialog Menu in Settings, we are changing the X to a <- button that lays inside of the box. Also please note the change to 20px rounded corners too!
UIS-29 Voice Command_004.pdf

---

Below is the most up-to-date color palette. Please let me know if you have any questions!

[keianhzo]

Thanks @jenniferhoang! I'm also going to need all the new icons in the settings panel.

[jenniferhoang]

No problem @keianhzo! Please see attached.
UIS-16 Settings_014 Assets.zip

[keianhzo]

Closing this as this dialog style got fixed with #703