Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Media controls show for non-video sources in VR video modes #776

Closed
caseyyee opened this issue Nov 17, 2018 · 3 comments
Closed

Media controls show for non-video sources in VR video modes #776

caseyyee opened this issue Nov 17, 2018 · 3 comments
Assignees
Labels
P3 Backlog

Comments

@caseyyee
Copy link
Contributor

FXR:
eaa4fc5

Hardware

Oculus Go

Steps to Reproduce

  1. Enter fullscreen
  2. Navigate to
    https://mixedreality.mozilla.org/fxr-html-tests/window-size.html
  3. Fullscreen
  4. Select VR video mode

Current Behavior

Media transport controls show. If you interact with the controls, the browser crashes.

Expected Behavior

For non-video sources, we should not be showing transport controls.

@MortimerGoro MortimerGoro self-assigned this Nov 19, 2018
@cvan cvan added this to the v1.1 milestone Nov 20, 2018
@cvan
Copy link
Contributor

cvan commented Nov 21, 2018

@caseyyee I recall you saying you saw some crashes with non-video sources? can you provide STR?

@cvan cvan added blocked P2 Fix in the next development iteration backlog and removed blocked labels Nov 21, 2018
@cvan cvan removed this from the v1.1 milestone Nov 21, 2018
@cvan
Copy link
Contributor

cvan commented Nov 21, 2018

From my testing, this is important because it is confusing to the user, but it does not block a user flow or crash. @caseyyee if you can reproduce with a crash, please post a comment with adb logcat | grep -i gecko logs, and we can escalate this issue. Thanks!

@MortimerGoro
Copy link
Contributor

I created #796 for now

@thenadj created a different UI for this scenario, but it's too much work for v1.1. We can address this later

@cvan cvan added P3 Backlog and removed P2 Fix in the next development iteration labels Nov 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 Backlog
Projects
None yet
Development

No branches or pull requests

3 participants