Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Crash upon loading navigation menu on Amazon.com #848

Closed
cvan opened this issue Nov 27, 2018 · 3 comments
Closed

Crash upon loading navigation menu on Amazon.com #848

cvan opened this issue Nov 27, 2018 · 3 comments
Assignees
Labels
bug This issue is a software or functional defect crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak P1 Fix in the current development iteration
Milestone

Comments

@cvan
Copy link
Contributor

cvan commented Nov 27, 2018

Hardware

Oculus Go
dcb38f3

Steps to Reproduce

  1. Launch https://amazon.com/.
  2. Press the Navigation in the top-left corner (i.e., the hamburger menu icon).
  3. Notice Firefox Reality crashes. (See crash report on Socorro.)

Current Behavior

Firefox Reality crashes upon loading JavaScript: (0). (See crash report on Socorro for java.net.URISyntaxException: at java.net.URI$Parser.fail(URI.java).)

Expected Behavior

Firefox Reality does not crash upon loading JavaScript: (0).

Context

Firefox Reality chokes on the URI, JavaScript: (0), when it is parsed by the URL parsing logic in the UI-Override code (added in PR #777).

Logs

See crash report on Socorro.
Callstack:

java.net.URISyntaxException
	at java.net.URI$Parser.fail(URI.java:2856)
	at java.net.URI$Parser.checkChars(URI.java:3029)
	at java.net.URI$Parser.parse(URI.java:3066)
	at java.net.URI.<init>(URI.java:590)
	at java.net.URI.create(URI.java:852)
	at org.mozilla.vrbrowser.browser.UserAgentOverride.lookupOverride(UserAgentOverride.java:46)
	at org.mozilla.vrbrowser.browser.SessionStore.onLoadRequest(SessionStore.java:949)
	at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:452)
	at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:402)
	at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:79)
	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:356)
	at android.os.Handler.handleCallback(Handler.java:751)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6143)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:889)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:779)
@cvan cvan added bug This issue is a software or functional defect P0 Hotfix or blocker during release preparation labels Nov 27, 2018
@cvan cvan added this to the v1.1 milestone Nov 27, 2018
@cvan cvan added the crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak label Nov 27, 2018
@bluemarvin
Copy link
Contributor

@cvan were you logged into amazon? I can't reproduce the crash.

@cvan cvan added P1 Fix in the current development iteration and removed P0 Hotfix or blocker during release preparation labels Nov 27, 2018
@cvan
Copy link
Contributor Author

cvan commented Nov 27, 2018

@cvan were you logged into amazon? I can't reproduce the crash.

nope, on a clean install.

you can reproduce by clicking the last link on https://webxr.sh/javascript-url

@bluemarvin
Copy link
Contributor

Thanks, was able to reproduce crash and verified my PR fixes the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a software or functional defect crash 🔥 i.e. severity=critical: crashes, loss of data, severe memory leak P1 Fix in the current development iteration
Projects
None yet
Development

No branches or pull requests

2 participants