-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate skill? #24
Comments
At first I wasn't convinced but really this Skill is "repeat what I say" and then there can be two modes, one-off or ongoing parroting. So yeah I feel like it makes sense to incorporate them. In terms of how to go about that, it seems like there'll be less messing around to update this Skill than doing a switcheroo to replace a default Skill with another. A couple of things:
The "repeat recent" Skill also looks like a brilliant addition to the Marketplace as a separate Skill. |
since this was the first skill ever using the converse method (the one i used to develop it actually) and it shares basically no code base with the current skill, i would like to retain commit history i wouldn't mind transferring the skill to mycroft org, either current approach taken by the parrot skill or something like what was done in stock skill would work to avoid skill conflicts the images will certainly need replacing, they were downloaded with a google search script |
also note the parrot skill now also includes the "repeat recent" intents, but takes into account message.context |
This skill could be replaced by https://github.com/JarbasSkills/skill-parrot
parrot includes PR #8 , solves #6 and adds extra functionality, both skills do basically the same.
In parrot skill i am blacklisting this skill because of issues linked above
Parrot skill very simple and is a good template to show new users the usage of converse method
The text was updated successfully, but these errors were encountered: