From 276e215cd6cb35a0486642550a79e9a0b5f6a73f Mon Sep 17 00:00:00 2001
From: Matthew B <106352182+artntek@users.noreply.github.com>
Date: Mon, 13 Jan 2025 11:26:05 -0800
Subject: [PATCH] add note about -XX:+UseG1GC

---
 docker/docker-entrypoint.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/docker/docker-entrypoint.sh b/docker/docker-entrypoint.sh
index 9ffdf6f33..fee795539 100755
--- a/docker/docker-entrypoint.sh
+++ b/docker/docker-entrypoint.sh
@@ -38,6 +38,10 @@ setTomcatEnv() {
     ################################
     ## MEMORY MANAGEMENT
     ################################
+    ## Garbage-First garbage collector is the default (Java17+), so don't need to set -XX:+UseG1GC
+    ## see:
+    ## https://docs.oracle.com/en/java/javase/17/gctuning/garbage-first-g1-garbage-collector1.html
+    ##
     MEMORY=""
     if [[ -z ${TOMCAT_MEM_MIN} ]] || [[ -z ${TOMCAT_MEM_MAX} ]]; then
         echo "tomcat max or min memory size not found; skipping memory settings"