Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable check on negative pressures #8

Open
ltalirz opened this issue Aug 11, 2020 · 3 comments
Open

disable check on negative pressures #8

ltalirz opened this issue Aug 11, 2020 · 3 comments

Comments

@ltalirz
Copy link
Member

ltalirz commented Aug 11, 2020

turin it into a warning until @dwsideriusNIST fixes the data

@dwsideriusNIST
Copy link
Collaborator

What is the best way to provide a warning, but not fail the pre-commit hook? I'm not finding working guidance on how to do this. My other test was to have the validate script output a warning, but still return sys.exit(0) - the pre-commit hook passes, but the warning text is not written to the console.

@ltalirz
Copy link
Member Author

ltalirz commented Aug 12, 2020

Hi Dan, I checked the code I had in mind and it turned out to be a setting of a specific linter.
I.e. simply returning sys.exit(0) (and adding a comment to change this once it's fixed) sounds like the right approach.

@dwsideriusNIST
Copy link
Collaborator

dwsideriusNIST commented Aug 12, 2020

I tracked down a solution: cd498c5. it includes the sys.exit(0) modification you pointed out, but also adding "verbose: true" to the pre-commit YML. Now the warnings are output, but the check passes regardless of errors.

I'm going to leave this open so that this change is undone after I audit the erroneous isotherms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants