Fix warnings in copygb, tocgrib2, and tocgrib2super utilities #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlysonStahl-NOAA
changed the title
AlysonStahl-NOAA
changed the title
| @@ -110,7 +110,7 @@ end subroutine getgb2p2 | |||
| call baopenw(lugo, fileo, iret1) | |||
| if (iret1 .ne. 0) then | |||
| write(6, fmt='(" Error opening output transmission file: ", & | |||
| A200)') fileo | |||
| &A200)') fileo | |||
There was a problem hiding this comment.
What is happening here? Why is there a line continuation character on the second line?
There was a problem hiding this comment.
The warnings for this one and tocgrib2super was for the lack of ampersand. I believe it's standard to have the ampersand there and at the end of the first line if the continued line is a string constant.
There was a problem hiding this comment.
Instead, just put it all on one line.
There was a problem hiding this comment.
There's a few other WRITE expressions using the same leading ampersand to address the -Wampersand warning which would result in pretty long lines, such as:
WRITE (6, FMT='(//, '' ******** RECAP OF THIS EXECUTION '', &
&''********'', /, 5X, ''READ '', I6, '' INDIVIDUAL IDS'', &
&/, 5X, ''WROTE '', I6, '' BULLETINS OUT FOR TRANSMISSION'', &
&//)') nrec, NBULDo we want to just put the shorter ones on one line, or address all of the other warnings this way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #813
Fixes #814
Fixes #815