You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hydrofabric3D::extend_transects_to_polygons() needs to be refactored into 3 separate functions/steps:
Determine transects that need extending given a polygon
Retrieve the distances to extend each transect in left and right directions
Apply extension distances to transects with flowlines
Right now these 3 steps are all under a single function and making maintaining/improving for performance tougher. Its hard to pinpoint slow points when so many steps are going on, particularly when the slowpoints are memory related
The text was updated successfully, but these errors were encountered:
Closing this issue as hydrofabric3D::extend_transects_to_polygons() has been heavily refactored
Changes can be see here and were brought in from this PR
Updated the utility functions that go into hydrofabric3D::extend_transects_to_polygons()
Made the code more maintainable by breaking logic in hydrofabric3D::extend_transects_to_polygons() into multiple self contained sub functions
BIG speed/memory optimization gain from changing a geos::geos_intersects() call into geos::geos_intersects_matrix() call in the hydrofabric3D::geos_bs_distance() function which run on every transect and thus gets a lot of use
hydrofabric3D::extend_transects_to_polygons()
needs to be refactored into 3 separate functions/steps:Right now these 3 steps are all under a single function and making maintaining/improving for performance tougher. Its hard to pinpoint slow points when so many steps are going on, particularly when the slowpoints are memory related
The text was updated successfully, but these errors were encountered: