Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on adding outage data to a system (especially time-series) #55

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

josephmckinsey
Copy link
Collaborator

I also plan on adding a unit test for this, since we don't test time-series outage data yet. That may be delayed until another PR.

Joseph McKinsey and others added 2 commits January 16, 2025 12:38
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.07%. Comparing base (635372d) to head (002daef).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   47.07%   47.07%           
=======================================
  Files          12       12           
  Lines         752      752           
=======================================
  Hits          354      354           
  Misses        398      398           
Flag Coverage Δ
unittests 47.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Public = false
```
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JuliaFormatter] reported by reviewdog 🐶

Suggested change
```
```

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@scdhulipala scdhulipala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephmckinsey josephmckinsey merged commit 4ae7b8f into main Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants