From b9fbca4965197c003573a24f4abbf0faff4fc79c Mon Sep 17 00:00:00 2001 From: Paul Gilman Date: Wed, 4 Dec 2024 08:40:05 -0800 Subject: [PATCH] Show variable label and value for upgrade script This is being used both when a variable name changes and when a variable's value changes, so showing "Changed 'variable_name' to: [variable value]" is confusing when the variable name changed but the variable value did not change. Showing "variable_name = [variable_value]" is clear in either case. --- src/project.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/project.cpp b/src/project.cpp index 5faa1e816e..04c7f9cb15 100644 --- a/src/project.cpp +++ b/src/project.cpp @@ -502,11 +502,11 @@ static void fcall_vuc_value( lk::invoke_t &cxt ) VersionUpgrade::log( VersionUpgrade::VAR_ADDED, "Added '" + label + "', " + vv_strtypes[type] + ": " + valstr, reason ) ); } - else + else // variable's value or its name may have changed { vuc->GetLog( vuc->GetName() ).push_back( VersionUpgrade::log( VersionUpgrade::VAR_CHANGED, - "Changed '" + label + "' to: " + valstr, reason ) ); + label + " = " + valstr, reason ) ); } cxt.result().assign( ok ? 1.0 : 0.0 );