Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LHS (PV Uncertainty) failing on MacOS #1417

Closed
sjanzou opened this issue Jun 13, 2023 · 2 comments · Fixed by #1782
Closed

LHS (PV Uncertainty) failing on MacOS #1417

sjanzou opened this issue Jun 13, 2023 · 2 comments · Fixed by #1782
Assignees
@sjanzou
Labels
bug
Milestone
2023 Release Patch 2

Comments

@sjanzou
Copy link
Collaborator

sjanzou commented Jun 13, 2023 •
edited by cpaulgilman
Loading

2022.11.21.r3.ssc.280

Issue reported on SAM forum: https://sam.nrel.gov/forum/forum-general/4253

Using attached project file and weather files.
2023.6.12_issue_4253.zip
@sjanzou sjanzou added the bug label Jun 13, 2023
@cpaulgilman
Copy link
Collaborator

LHS also fails on Linux with a hard crash after uncertainty simulations finish running. Tested in Linux Mint 21.1 (Cinnamon 5.6.8).

@cpaulgilman cpaulgilman added this to the SAM Fall 2023 Release milestone Jul 24, 2023
sjanzou added a commit that referenced this issue Oct 18, 2023
@sjanzou
Fix SAM issue #1417, tested macOS 14.0
736ade5 
Note that stochastic simulations not currently available or supported for hybrid configurations.
@sjanzou sjanzou linked a pull request Oct 18, 2023 that will close this issue
Fix SAM issue #1417, tested macOS 14.0 #1504
Closed
@sjanzou sjanzou mentioned this issue Oct 20, 2023
Closed
@cpaulgilman
Copy link
Collaborator

Reported for SAM 2023.12.17 for Mac: https://sam.nrel.gov/forum/forum-general/4253

sjanzou added a commit that referenced this issue May 28, 2024
@sjanzou
Change from wxExecute to system call to address #1417
926395f
sjanzou added a commit that referenced this issue Jun 3, 2024
@sjanzou
Update lhs.bin and stepwise.bin to address #1417
a5ebe00
@sjanzou sjanzou removed a link to a pull request Jun 3, 2024
Fix SAM issue #1417, tested macOS 14.0 #1504
Closed
@sjanzou sjanzou linked a pull request Jun 3, 2024 that will close this issue
Update lhs.bin and stepwise.bin to address #1417 #1782
Merged
sjanzou added a commit that referenced this issue Jun 6, 2024
@sjanzou
Merge pull request #1782 from NREL/SAM_1417_lhs
ae13f4f 
Update lhs.bin and stepwise.bin to address #1417
dguittet added a commit that referenced this issue Jun 25, 2024
@dguittet @sjanzou @cpaulgilman
Develop merge (#1799)
4ee1368 
* Update lhs.bin and stepwise.bin to address #1417

* Not sure why GitHub Actions failing when Mac binaries only thing updated

* Fix base branch for GitHub Actions - patch

* Rerun defaults on Windows for failing GitHub Actions

* Fix indifference point macro description (#1788)

* Update PV PDF report templates (#1789)

* Fix Federal depreciation calculation in host_developer.xlsx (#1793)

Cell CashFlow!B398 incorrectly referred to $C$141 for federal custom depreciation allocation which caused divide by zero errors that propagated through workbook all the way to LCOE and NPV results.

This issue only affected Host Developer send-to-Excel with equations when 20-yr SL allocation (Inputs!C141) is set to zero.

Checked that all other FOM spreadsheets do not have this problem.

* UI message for battery grid charging with PBI (#1792)

Also trigger message on_change so message appears when you switch to Battery Dispatch pages.

* Marine Energy documentation revisions (#1790)

* Fix base branch in Github CI (#1779)

* fix base branch

* fix ref name

* set default branch to patch

* update test results

---------

Co-authored-by: sjanzou <[email protected]>
Co-authored-by: Steven Janzou <[email protected]>
Co-authored-by: Paul Gilman <[email protected]>
dguittet added a commit that referenced this issue Jun 25, 2024
@dguittet @sjanzou @cpaulgilman
Develop merge (#1802)
a0c35b9 
* Update lhs.bin and stepwise.bin to address #1417

* Not sure why GitHub Actions failing when Mac binaries only thing updated

* Fix base branch for GitHub Actions - patch

* Rerun defaults on Windows for failing GitHub Actions

* Fix indifference point macro description (#1788)

* Update PV PDF report templates (#1789)

* Update PV Tracking and Orientation diagram

Old version was misleading for one-axis trackers.

Delete extra copies of image file.

* Update documentation for PV tracking and orientation

* Revise PVWatts tilt and azimuth descriptions

* Fix Federal depreciation calculation in host_developer.xlsx (#1793)

Cell CashFlow!B398 incorrectly referred to $C$141 for federal custom depreciation allocation which caused divide by zero errors that propagated through workbook all the way to LCOE and NPV results.

This issue only affected Host Developer send-to-Excel with equations when 20-yr SL allocation (Inputs!C141) is set to zero.

Checked that all other FOM spreadsheets do not have this problem.

* UI message for battery grid charging with PBI (#1792)

Also trigger message on_change so message appears when you switch to Battery Dispatch pages.

* Marine Energy documentation revisions (#1790)

* Fix base branch in Github CI (#1779)

* fix base branch

* fix ref name

* set default branch to patch

* Address hybrid SAM lk scripting issues in #1636

* Squashed commit of the following:

commit c5f39d5
Author: Paul Gilman <[email protected]>
Date:   Fri Jun 14 16:13:53 2024 -0700

    Fix CEC Help topic

commit d44d433
Author: Paul Gilman <[email protected]>
Date:   Fri Jun 14 16:00:05 2024 -0700

    Help revisions for PV temperature, spectral, and optical models

    * Revise IEC 61853 topic to explain temperature, spectral, and optical models.

    * Add note for CEC model to explain air mass model.

commit 05581df
Author: Paul Gilman <[email protected]>
Date:   Fri Jun 14 15:58:13 2024 -0700

    UI fixes for PV optical and spectral models

    * Display all available data for Sandia module model so users can see model coefficient values in UI without opening library CSV file.

    * Improve labeling of inputs for IEC 61853 module model

* Improve Documentation of IEC 61858 temperature, optical, and spectral models (#1795)

* UI fixes for PV optical and spectral models

* Display all available data for Sandia module model so users can see model coefficient values in UI without opening library CSV file.

* Improve labeling of inputs for IEC 61853 module model

* Help revisions for PV temperature, spectral, and optical models

* Revise IEC 61853 topic to explain temperature, spectral, and optical models.

* Add note for CEC model to explain air mass model.

* Fix CEC Help topic

* Improve lk select_inputs() function description

* revert test_results_win64.csv

---------

Co-authored-by: sjanzou <[email protected]>
Co-authored-by: Steven Janzou <[email protected]>
Co-authored-by: Paul Gilman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjanzou sjanzou

Labels
bug
Projects
None yet
Milestone
2023 Release Patch 2
Development

Successfully merging a pull request may close this issue.

Update lhs.bin and stepwise.bin to address #1417 NREL/SAM
3 participants
@sjanzou @janinefreeman @cpaulgilman