Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Add insert overloads that take value_type as input #410

Open
PointKernel opened this issue Dec 19, 2023 · 0 comments
Open
Labels
good first issue Good for newcomers P2: Nice to have Desired, but not necessary type: feature request New feature request

Comments

@PointKernel
Copy link
Member

PointKernel commented Dec 19, 2023

Is your feature request related to a problem? Please describe.

Firstly proposed by @sleeepyjack in #407 (comment)

The current heterogeneous insert feature requires users to pass an explicit pair type when invoking the device insert functions. So the legacy behavior like:

  set_ref.insert({key, payload});

is no longer supported.

Describe the solution you'd like

Similar to STL insert, it would be nice to add an overload of insert taking value_type as input thus the sample code can work as well.

@PointKernel PointKernel added type: feature request New feature request P2: Nice to have Desired, but not necessary labels Dec 19, 2023
@PointKernel PointKernel added the good first issue Good for newcomers label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P2: Nice to have Desired, but not necessary type: feature request New feature request
Projects
None yet
Development

No branches or pull requests

1 participant