Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding per CTK major.minor optional dependencies? #399

Open
leofang opened this issue Jan 15, 2025 · 0 comments
Open

Consider adding per CTK major.minor optional dependencies? #399

leofang opened this issue Jan 15, 2025 · 0 comments
Labels
cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module packaging Anything related to wheels or Conda packages triage Needs the team's attention

Comments

@leofang
Copy link
Member

leofang commented Jan 15, 2025

I actually want these jobs if possible, yes, but I can't do so with the existing [all] notation for installing the latest CUDA wheels (we let them float and do not add version constraints). To support testing CUDA 12.0 wheels it'd mean we need to add more optional tags like [cu120]. We could consider this in the future, but I am hesitant to do so now.

And without the extra tags, these jobs are redundant because it's the latest (12.6) wheels being installed for testing, which has been covered by other jobs.

Originally posted by @leofang in #393 (comment)
@github-actions github-actions bot added the triage Needs the team's attention label Jan 15, 2025
@leofang leofang mentioned this issue Jan 15, 2025
Merged
@leofang leofang added packaging Anything related to wheels or Conda packages cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module packaging Anything related to wheels or Conda packages triage Needs the team's attention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leofang