Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛[BUG]: pytest dalaloader tests fail on local development environment #452

Closed
akshaysubr opened this issue Apr 16, 2024 · 2 comments
Closed
Assignees
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@akshaysubr
Copy link
Collaborator

akshaysubr commented Apr 16, 2024

Version

main

On which installation method(s) does this occur?

Source

Describe the issue

pytest failures with dataloader tests since data artifacts are not available locally. This is a major challenge with local development and should be fixed.

Minimum reproducible example

Just running the full test suite

Relevant log output

No response

Environment details

No response

@akshaysubr akshaysubr added bug Something isn't working ? - Needs Triage Need team to review and classify labels Apr 16, 2024
@ktangsali
Copy link
Collaborator

@akshaysubr any particular test you are seeing this failure? We use the @nfsdata_or_fail which should ideally be skipping such tests in absence of data.

@ktangsali
Copy link
Collaborator

This is no longer an issue. Closing. Please re-open if the issue persists.

pytest datapipes/
================================================================= test session starts ==================================================================
platform linux -- Python 3.12.3, pytest-8.1.1, pluggy-1.5.0
rootdir: /workspace/development_workspace/modulus
configfile: pyproject.toml
plugins: anyio-4.8.0, hypothesis-5.35.1, xdoctest-1.0.2, rerunfailures-15.0, shard-0.1.2, xdist-3.6.1, flakefinder-1.1.0
collected 87 items / 4 skipped                                                                                                                         
Running 87 items in this shard

datapipes/test_ahmed_body.py ss                                                                                                                  [  2%]
datapipes/test_climate.py sssssssssssssssssssssssssss                                                                                            [ 33%]
datapipes/test_darcy.py sssssssssssssssss                                                                                                        [ 52%]
datapipes/test_drivaernet.py ss                                                                                                                  [ 55%]
datapipes/test_kelvin_helmholtz.py sssssssssssssssssssssssssssss                                                                                 [ 88%]
datapipes/test_mesh_datapipe.py ss                                                                                                               [ 90%]
datapipes/test_stokes.py ss                                                                                                                      [ 93%]
datapipes/test_synthetic.py ssssss                                                                                                               [100%]

================================================================= 91 skipped in 1.94s ==================================================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants