Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retraining recipe for DoMINO and removing fixed non-dimensionalization from domino datapipe #776

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

RishikeshRanade
Copy link
Collaborator

@RishikeshRanade RishikeshRanade commented Feb 2, 2025

Modulus Pull Request

Description

I have added a minimal retraining recipe and validated it with Luminary Cloud dataset we had generated for SC'24. Also, the non-dimensionalization of flow variables is moved out of domino_datapipe.py to openfoam_datapipe.py so that users can have more control over the order and type of solution variables they can model.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

@Alexey-Kamenev
Copy link
Collaborator

/blossom-ci

Copy link
Collaborator

@Alexey-Kamenev Alexey-Kamenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RishikeshRanade RishikeshRanade merged commit 161d416 into NVIDIA:main Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants