Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix: dff8 reference design #8

Open
luca-valente opened this issue Dec 3, 2024 · 2 comments
Open

Minor fix: dff8 reference design #8

luca-valente opened this issue Dec 3, 2024 · 2 comments

Comments

@luca-valente
Copy link

Hello,

I found a minor issue with the dff8 reference design.

The reference solution implements a

  initial
    q = 8'h0;

which makes the test fail when the LLM's answer is simply

module top_module (
  input clk,
  input [7:0] d,
  output reg [7:0] q
);

  always @(posedge clk)
    q <= d;

endmodule

which in my opinion is correct.

Thank you for your attention!!

Luca

@npfet
Copy link
Collaborator

npfet commented Dec 3, 2024

Hi Luca, good catch- I will add this to a list of fixes to get in before an upcoming update. We have a handful of consistency fixes for the VerilogEval v2 release as well (I'd expect it to be pushed somewhere in the next month or two... we're mostly finalizing benchmarking SOTA LLMs against v2 internally before pushing the fixes). We will only maintain an errata list for the v1 release since we want to have a consistent dataset to compare against prior papers.

Thanks,

Nate

@luca-valente-sony
Copy link

Thank you for the feedback 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants