-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Change FLINT's matrix structs to accomodate v3.3.0 #1999
base: master
Are you sure you want to change the base?
Conversation
Since v3.3.0, they rely on stride instead of pointers to rows
667d40e
to
af7a0a5
Compare
I think it would make sense to have some branch ping @fingolfin |
We can have a look together sometime this week |
You can check the remaining things by grepping for |
The one in The other one is in |
The code in But it would still be possible (and desirable) to have an optimized version, and perhaps also for more matrix types: essentially, this function applies a permutation to the rows of the input matrix. We can still do that a lot more efficiently than via swaps if we have a buffer for one row available and otherwise use Ideally FLINT would offer an API for applying such a permutation, then we'd not have to mess with the internals. But AFAIK this doesn't exist, just for "reversing" all rows and for swapping two rows? |
Note that Hecke also may need some adjustments, e.g. its |
Since v3.3.0, they rely on stride instead of pointers to rows.
There are still some unsafe things that has to be fixed, I didn't know how to fix them.