From 4ffbc9352685cecbb78c9bed84f2f8895711ea19 Mon Sep 17 00:00:00 2001 From: "dragos.stefanache" Date: Tue, 10 Dec 2024 11:16:23 +0200 Subject: [PATCH] Adds changes based on code review --- blocks/header/header.css | 15 +++++++-------- blocks/header/header.js | 1 + 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/blocks/header/header.css b/blocks/header/header.css index 2ec8085..6ed67a1 100644 --- a/blocks/header/header.css +++ b/blocks/header/header.css @@ -15,8 +15,7 @@ header { } } -nav { - box-sizing: border-box; +.nav { display: grid; grid-template: 'hamburger brand tools' var(--nav-height) @@ -29,6 +28,12 @@ nav { padding-inline: var(--content-padding-inline); font-family: var(--body-font-family); + @media (min-width: 1280px) { + display: flex; + justify-content: space-between; + gap: 0 32px; + } + &[aria-expanded='true'] { grid-template: 'hamburger brand' var(--nav-height) @@ -43,12 +48,6 @@ nav { } } - @media (min-width: 1280px) { - display: flex; - justify-content: space-between; - gap: 0 32px; - } - p { margin: 0; line-height: 1; diff --git a/blocks/header/header.js b/blocks/header/header.js index 09d2e67..461b906 100644 --- a/blocks/header/header.js +++ b/blocks/header/header.js @@ -117,6 +117,7 @@ export default async function decorate(block) { block.textContent = ''; const nav = document.createElement('nav'); nav.id = 'nav'; + nav.classList.add('nav'); while (fragment.firstElementChild) nav.append(fragment.firstElementChild); const classes = ['brand', 'sections', 'tools'];