Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynomite and Redis streams #668

Open
jkimalane opened this issue May 28, 2019 · 5 comments
Open

Dynomite and Redis streams #668

jkimalane opened this issue May 28, 2019 · 5 comments
Assignees

Comments

@jkimalane
Copy link

I'm wondering, are there any major show stoppers why streams commands can't be handled by dynomite? Maybe someone who is more deeply involved with dynomite and has deep understanding of dynmoite internals can elaborate this bit more. If it's not that hard and does not require massive amount of changes, I could try to implement those X for adding support for streams data type.

@jkimalane
Copy link
Author

I'm bit stuck as I can't figure out how multibulk responses are forwarded from redis server through dynomite proxy to redis client. Commands like XINFO STREAM or XRANGE return multibulks and according to comments in dyn_redis.c only commands SSCAN/HSCAN/ZSCAN are handled. To me it seems that recursion is needed to handle this case.

@jkimalane
Copy link
Author

There is a pending pull-request #675 which provides basic streams support. Although there is a timing issue but in general, all streams related commands are supported.

@ipapapa
Copy link
Contributor

ipapapa commented Jun 27, 2019

@smukil was working on some changes in this area. I will let him handle this issue.

@jkimalane
Copy link
Author

any news about this one?

@smukil
Copy link
Contributor

smukil commented Oct 4, 2019

@jkimalane We're strapped for bandwidth at the moment unfortunately, but we're in the process of on-boarding more developers on Dynomite, so we should be able to move faster in the coming weeks and get the patch in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants