From 03ba2e373dc5547fea24365b9a92d25bc0738b0d Mon Sep 17 00:00:00 2001 From: thiagodeev Date: Fri, 31 Jan 2025 11:42:11 -0300 Subject: [PATCH] Fix SubscribeTransactionStatus with new Juno update --- rpc/websocket.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/rpc/websocket.go b/rpc/websocket.go index 65f6c58d..a1475ad2 100644 --- a/rpc/websocket.go +++ b/rpc/websocket.go @@ -93,14 +93,9 @@ func (provider *WsProvider) SubscribePendingTransactions(ctx context.Context, pe // - clientSubscription: The client subscription object, used to unsubscribe from the stream and to get errors // - error: An error, if any func (provider *WsProvider) SubscribeTransactionStatus(ctx context.Context, newStatus chan<- *NewTxnStatusResp, transactionHash *felt.Felt) (*client.ClientSubscription, error) { - sub, err := provider.c.SubscribeWithSliceArgs(ctx, "starknet", "_subscribeTransactionStatus", newStatus, transactionHash, WithBlockTag("latest")) + sub, err := provider.c.SubscribeWithSliceArgs(ctx, "starknet", "_subscribeTransactionStatus", newStatus, transactionHash) if err != nil { - return nil, tryUnwrapToRPCErr(err, ErrTooManyBlocksBack, ErrBlockNotFound) + return nil, tryUnwrapToRPCErr(err) } - // TODO: wait for Juno to implement this. This is the correct implementation by the spec - // sub, err := provider.c.SubscribeWithSliceArgs(ctx, "starknet", "_subscribeTransactionStatus", newStatus, transactionHash) - // if err != nil { - // return nil, tryUnwrapToRPCErr(err) - // } return sub, nil }